mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
41 lines
1.8 KiB
TypeScript
41 lines
1.8 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { mkdtempSync, writeFileSync, chmodSync, readFileSync, rmSync, existsSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { npmInstallRuntime } from "../../bin/cli/runtime/nativeDeps.mjs";
|
|
|
|
test("issue #10713: npmInstallRuntime requests --allow-scripts for its own fully-controlled runtime dependency", () => {
|
|
const fakeBinDir = mkdtempSync(join(tmpdir(), "omniroute-fakenpm-"));
|
|
const argvLog = join(fakeBinDir, "argv.log");
|
|
const npmScript = join(fakeBinDir, "npm");
|
|
writeFileSync(npmScript, `#!/usr/bin/env bash\nprintf '%s\\n' "$@" > "${argvLog}"\nexit 0\n`);
|
|
chmodSync(npmScript, 0o755);
|
|
|
|
const originalPath = process.env.PATH;
|
|
const originalDataDir = process.env.DATA_DIR;
|
|
const fakeDataDir = mkdtempSync(join(tmpdir(), "omniroute-fakedata-"));
|
|
try {
|
|
process.env.PATH = `${fakeBinDir}:${originalPath}`;
|
|
process.env.DATA_DIR = fakeDataDir;
|
|
|
|
const ok = npmInstallRuntime(["better-sqlite3@12.10.1"], { silent: true });
|
|
|
|
assert.equal(ok, true, "npm 12 exits 0 even when it silently skipped install scripts");
|
|
assert.ok(existsSync(argvLog), "fake npm should have been invoked");
|
|
|
|
const argv = readFileSync(argvLog, "utf8");
|
|
|
|
assert.ok(
|
|
argv.includes("--allow-scripts=better-sqlite3@12.10.1"),
|
|
"npm must be told to allow-scripts for its own runtime dep. argv was:\n" + argv
|
|
);
|
|
} finally {
|
|
process.env.PATH = originalPath;
|
|
if (originalDataDir === undefined) delete process.env.DATA_DIR;
|
|
else process.env.DATA_DIR = originalDataDir;
|
|
rmSync(fakeBinDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
rmSync(fakeDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|