Files
OmniRoute/tests/unit/cli-provider-catalog-full-10080.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

153 lines
5.9 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// #10080 — `loadAvailableProviders()` always returned the 6-entry
// COMMON_PROVIDERS fallback, so `omniroute keys add <provider>` rejected ~290 of
// the ~296 catalog providers with "Unknown provider". Two independent causes:
// 1. the parser required `typescript`, a devDependency absent from published
// installs, and swallowed the failure;
// 2. it read constants/providers.ts, which after the god-file decomposition
// holds only re-exports plus an empty `FREE_PROVIDERS = {}`.
const ROOT_DIR = path.resolve(".");
const { extractProviderBlocks, loadAvailableProviders, COMMON_PROVIDERS } =
await import("../../bin/cli/provider-catalog.mjs");
test("extractProviderBlocks handles the shapes the real catalog files use", () => {
const source = `
// A comment with a stray { brace } that must not confuse the walk.
export const NOAUTH_PROVIDERS = {
opencode: {
id: "opencode",
alias: "oc",
name: "OpenCode Free",
noAuth: true,
hasFree: true,
/* block comment with } */
notice: {
text: "Nested object — its keys must not surface as providers.",
},
},
"duckduckgo-web": {
id: "duckduckgo-web",
name: "DuckDuckGo AI Chat",
hasFree: true,
},
legacy: {
id: "legacy",
name: "Legacy" + " Provider",
website: "https://example.com/a{b}c",
deprecated: true,
passthroughModels: true,
},
};
`;
const providers = extractProviderBlocks(source);
assert.deepEqual(
providers.map((p) => p.id),
["opencode", "duckduckgo-web", "legacy"],
"quoted keys must parse, nested object keys must not leak"
);
assert.equal(providers[0].alias, "oc");
assert.equal(providers[0].hasFree, true);
assert.equal(providers[0].category, "noauth");
// A quoted key with no explicit alias/website yields nulls, not undefined.
assert.equal(providers[1].alias, null);
assert.equal(providers[1].website, null);
// Concatenated strings keep the first literal; braces inside strings survive.
assert.equal(providers[2].name, "Legacy");
assert.equal(providers[2].website, "https://example.com/a{b}c");
assert.equal(providers[2].deprecated, true);
assert.equal(providers[2].passthroughModels, true);
});
test("category comes from the prefix before _PROVIDERS, including suffixed exports", () => {
const mk = (name: string) => `export const ${name} = { a: { id: "a", name: "A" } };`;
assert.equal(extractProviderBlocks(mk("NOAUTH_PROVIDERS"))[0].category, "noauth");
assert.equal(extractProviderBlocks(mk("WEB_COOKIE_PROVIDERS"))[0].category, "web-cookie");
assert.equal(extractProviderBlocks(mk("APIKEY_PROVIDERS"))[0].category, "api-key");
// The decomposition introduced suffixed family exports; these are still api-key.
assert.equal(extractProviderBlocks(mk("APIKEY_PROVIDERS_GATEWAYS"))[0].category, "api-key");
assert.equal(extractProviderBlocks(mk("APIKEY_PROVIDERS_REGIONAL"))[0].category, "api-key");
});
test("an unbalanced literal terminates and keeps what was parsed", () => {
// Regression for an infinite loop: a missing `},` (see #10093) left the outer
// scan resetting its regex lastIndex to 0 forever.
const broken = `
export const APIKEY_PROVIDERS_GATEWAYS = {
good: { id: "good", name: "Good" },
broken: {
id: "broken",
name: "Broken",
other: {
id: "other",
name: "Other",
},
`;
const providers = extractProviderBlocks(broken);
assert.ok(providers.length >= 1, "entries before the damage are still recovered");
assert.equal(providers[0].id, "good");
});
test("loadAvailableProviders reads the decomposed catalog, not the 6-entry fallback", () => {
const providers = loadAvailableProviders({ rootDir: ROOT_DIR });
assert.ok(
providers.length > COMMON_PROVIDERS.length,
`expected the real catalog, got the ${providers.length}-entry fallback`
);
// Lower bound rather than an exact count so adding providers does not break this.
assert.ok(providers.length > 200, `expected 200+ providers, got ${providers.length}`);
const byId = new Map(providers.map((p) => [p.id, p]));
for (const id of ["cerebras", "groq", "gemini", "siliconflow", "opencode", "kiro"]) {
assert.ok(byId.has(id), `${id} missing from the catalog`);
}
assert.equal(byId.get("opencode")?.category, "noauth");
assert.equal(byId.get("kiro")?.category, "oauth");
assert.equal(byId.get("cerebras")?.category, "api-key");
assert.ok(providers.filter((p) => p.hasFree).length > 50, "free-tier flags should survive");
// ids are unique — the apikey barrel spreads family files that this walk also
// visits directly, so duplicates must be collapsed.
assert.equal(new Set(providers.map((p) => p.id)).size, providers.length);
});
test("falls back to COMMON_PROVIDERS when no catalog is present", () => {
const emptyRoot = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-empty-root-"));
try {
const providers = loadAvailableProviders({ rootDir: emptyRoot });
assert.equal(providers.length, COMMON_PROVIDERS.length);
assert.equal(providers[0].id, "openai");
} finally {
fs.rmSync(emptyRoot, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
});
test("an explicit catalogPath still overrides the directory walk", () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-catalog-"));
try {
const file = path.join(dir, "custom.ts");
fs.writeFileSync(
file,
`export const APIKEY_PROVIDERS = { only: { id: "only", name: "Only" } };`
);
const providers = loadAvailableProviders({ rootDir: ROOT_DIR, catalogPath: file });
assert.deepEqual(
providers.map((p) => p.id),
["only"]
);
} finally {
fs.rmSync(dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
});