mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
67 lines
2.8 KiB
TypeScript
67 lines
2.8 KiB
TypeScript
import { describe, it, before, after } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// HOME must be overridden BEFORE importing cliRuntime.ts — the module computes
|
|
// EXPECTED_PARENT_PATHS (the known-path realpath containment check) once at
|
|
// import time from os.homedir().
|
|
const fakeHome = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-7774-home-"));
|
|
const realBinDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-7774-realbin-"));
|
|
|
|
const savedEnv: Record<string, string | undefined> = {
|
|
HOME: process.env.HOME,
|
|
USERPROFILE: process.env.USERPROFILE,
|
|
PATH: process.env.PATH,
|
|
CLI_CLAUDE_BIN: process.env.CLI_CLAUDE_BIN,
|
|
CLI_EXTRA_PATHS: process.env.CLI_EXTRA_PATHS,
|
|
npm_config_prefix: process.env.npm_config_prefix,
|
|
};
|
|
|
|
process.env.HOME = fakeHome;
|
|
process.env.USERPROFILE = fakeHome;
|
|
delete process.env.CLI_CLAUDE_BIN;
|
|
delete process.env.CLI_EXTRA_PATHS;
|
|
process.env.npm_config_prefix = path.join(fakeHome, "npm-prefix-unused");
|
|
|
|
const { getCliRuntimeStatus, getKnownToolPaths } =
|
|
await import("../../src/shared/services/cliRuntime.ts");
|
|
|
|
function makeExecutable(filePath: string, content: string) {
|
|
fs.writeFileSync(filePath, content);
|
|
if (process.platform !== "win32") fs.chmodSync(filePath, 0o755);
|
|
}
|
|
|
|
describe("#7774 — known-path short-circuit hides a genuinely runnable Claude binary", () => {
|
|
before(() => {
|
|
const poisonedCandidate = path.join(fakeHome, ".local", "bin", "claude");
|
|
fs.mkdirSync(poisonedCandidate, { recursive: true });
|
|
|
|
const known = getKnownToolPaths("claude");
|
|
assert.ok(known.includes(poisonedCandidate));
|
|
|
|
const realClaude = path.join(realBinDir, "claude");
|
|
makeExecutable(realClaude, "#!/bin/sh\necho '2.1.215 (Claude Code)'\n");
|
|
// Prepend realBinDir rather than replacing PATH outright — locateCommand()
|
|
// spawns `sh`/`where.exe` itself using this same PATH, so the standard
|
|
// system bin dirs (containing `sh`) must stay resolvable too.
|
|
process.env.PATH = [realBinDir, savedEnv.PATH].filter(Boolean).join(path.delimiter);
|
|
});
|
|
|
|
after(() => {
|
|
for (const [key, value] of Object.entries(savedEnv)) {
|
|
if (value === undefined) delete (process.env as Record<string, string | undefined>)[key];
|
|
else process.env[key] = value;
|
|
}
|
|
fs.rmSync(fakeHome, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.rmSync(realBinDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
it("should still find and report Claude as installed+runnable via PATH fallback", async () => {
|
|
const result = await getCliRuntimeStatus("claude");
|
|
assert.equal(result.installed, true, `expected installed=true, got reason=${result.reason}`);
|
|
assert.equal(result.runnable, true, `expected runnable=true, got reason=${result.reason}`);
|
|
});
|
|
});
|