mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-10 08:52:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
67 lines
2.4 KiB
TypeScript
67 lines
2.4 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { register } from "node:module";
|
|
import Module from "node:module";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// #8826: better-sqlite3 v12 loads its native addon lazily -- import("better-sqlite3")
|
|
// SUCCEEDS and only new Database() throws "Could not locate the bindings file" when
|
|
// there is no .node binding for the runtime ABI (e.g. CachyOS + Node v26 via AUR).
|
|
// openSqliteDatabase() only fell back when the *import* failed; the construction-time
|
|
// failure was translated into "Run: omniroute runtime repair" guidance and aborted.
|
|
|
|
const FIXTURE_DIR = new URL("fixtures/", import.meta.url).pathname;
|
|
const hookPath = path.join(FIXTURE_DIR, "8826-mock-better-sqlite3.mjs");
|
|
|
|
// Register the ESM hook to return a module whose Database constructor throws
|
|
register(hookPath, import.meta.url);
|
|
|
|
// Patch Module._load so CJS createRequire("better-sqlite3") in driverFactory.ts
|
|
// also gets a constructor that throws the bindings error.
|
|
const originalLoad = Module._load;
|
|
Module._load = function patchedLoad(request, parent, isMain) {
|
|
if (request === "better-sqlite3") {
|
|
function FakeBetterSqlite() {
|
|
throw new Error(
|
|
"Could not locate the bindings file. Tried:\n" + " -> /fake/path/better_sqlite3.node"
|
|
);
|
|
}
|
|
return FakeBetterSqlite;
|
|
}
|
|
// @ts-expect-error Module._load is a CJS internal
|
|
return originalLoad.call(this, request, parent, isMain);
|
|
};
|
|
|
|
const { openOmniRouteDb } = await import("../../bin/cli/sqlite.mjs");
|
|
|
|
test("#8826: openOmniRouteDb() falls back to node:sqlite when better-sqlite3 native binding is missing (construction-time failure)", async (t) => {
|
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-8826-"));
|
|
t.after(() => {
|
|
try {
|
|
fs.rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {}
|
|
Module._load = originalLoad;
|
|
});
|
|
|
|
const origDataDir = process.env.DATA_DIR;
|
|
process.env.DATA_DIR = tmpDir;
|
|
t.after(() => {
|
|
if (origDataDir) {
|
|
process.env.DATA_DIR = origDataDir;
|
|
} else {
|
|
delete process.env.DATA_DIR;
|
|
}
|
|
});
|
|
|
|
const result = await openOmniRouteDb();
|
|
|
|
assert.ok(result.db, "openOmniRouteDb() should return a working db adapter");
|
|
assert.equal(
|
|
result.db.driver,
|
|
"node:sqlite",
|
|
"should fall back to node:sqlite when better-sqlite3 constructor throws (#8826)"
|
|
);
|
|
});
|