mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
76 lines
3.3 KiB
TypeScript
76 lines
3.3 KiB
TypeScript
// Regression coverage for the systray2 runtime swap (port of upstream PR #1080).
|
|
// The bug upstream: the bundled Go binary in node_modules/systray2/traybin
|
|
// sometimes ships without the executable bit on macOS/Linux, causing the tray
|
|
// to spawn() with EACCES and the icon never to appear.
|
|
//
|
|
// We can't load the real native binary in unit tests, but we can verify the
|
|
// pure helpers that drive the swap: the package + version pin and the
|
|
// chmod helper's behavior on a synthetic binary tree.
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { mkdtempSync, mkdirSync, rmSync, writeFileSync, statSync, chmodSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import {
|
|
SYSTRAY_PACKAGE,
|
|
SYSTRAY_VERSION,
|
|
chmodSystrayBinAt,
|
|
resolveSystrayBinName,
|
|
} from "../../bin/cli/runtime/trayRuntime.ts";
|
|
|
|
test("systray2 is pinned to a 2.x version (PR #1080 fix)", () => {
|
|
assert.equal(SYSTRAY_PACKAGE, "systray2");
|
|
// The original systray@1.0.5 binary is incompatible with modern macOS dyld;
|
|
// upstream PR #1080 moved to the systray2 2.x line. Pin must stay ≥ 2.x.
|
|
assert.match(SYSTRAY_VERSION, /^2\./, `expected systray2@2.x, got ${SYSTRAY_VERSION}`);
|
|
});
|
|
|
|
test("resolveSystrayBinName returns *_release name on all platforms (#8609)", () => {
|
|
assert.equal(resolveSystrayBinName("win32"), "tray_windows_release.exe");
|
|
assert.equal(resolveSystrayBinName("darwin"), "tray_darwin_release");
|
|
assert.equal(resolveSystrayBinName("linux"), "tray_linux_release");
|
|
});
|
|
|
|
test("chmodSystrayBinAt sets +x on the bundled tray binary when present", () => {
|
|
const root = mkdtempSync(join(tmpdir(), "omniroute-systray-bin-"));
|
|
try {
|
|
const platform = process.platform === "win32" ? "linux" : process.platform;
|
|
const binName = resolveSystrayBinName(platform)!;
|
|
const binDir = join(root, "node_modules", "systray2", "traybin");
|
|
mkdirSync(binDir, { recursive: true });
|
|
const binPath = join(binDir, binName);
|
|
writeFileSync(binPath, "#!/bin/sh\nexit 0\n", { mode: 0o644 });
|
|
chmodSync(binPath, 0o644); // explicit: not executable
|
|
const result = chmodSystrayBinAt(root, platform);
|
|
assert.equal(result.changed, true, "expected chmodSystrayBinAt to chmod the bin");
|
|
// 0o111 covers the three execute bits — assert at least one is set.
|
|
const mode = statSync(binPath).mode & 0o777;
|
|
assert.ok((mode & 0o111) !== 0, `expected exec bits on bin, got mode=${mode.toString(8)}`);
|
|
} finally {
|
|
rmSync(root, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("chmodSystrayBinAt is a no-op when the binary doesn't exist", () => {
|
|
const root = mkdtempSync(join(tmpdir(), "omniroute-systray-bin-"));
|
|
try {
|
|
const result = chmodSystrayBinAt(root, "linux");
|
|
assert.equal(result.changed, false);
|
|
assert.equal(result.reason, "missing");
|
|
} finally {
|
|
rmSync(root, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("chmodSystrayBinAt returns missing on win32 when binary is absent (#8609)", () => {
|
|
const root = mkdtempSync(join(tmpdir(), "omniroute-systray-bin-"));
|
|
try {
|
|
const result = chmodSystrayBinAt(root, "win32");
|
|
assert.equal(result.changed, false);
|
|
assert.equal(result.reason, "missing");
|
|
} finally {
|
|
rmSync(root, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|