mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
63 lines
3.0 KiB
TypeScript
63 lines
3.0 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { readFileSync, mkdtempSync, mkdirSync, existsSync, statSync, rmSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
|
|
const update = await import("../../bin/cli/commands/update.mjs");
|
|
|
|
const REPO_ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..", "..");
|
|
const REAL_VERSION = JSON.parse(
|
|
readFileSync(path.join(REPO_ROOT, "package.json"), "utf-8")
|
|
).version;
|
|
|
|
// #3295 issue 1: getCurrentVersion() must resolve package.json relative to the
|
|
// script, not process.cwd(). When OmniRoute is installed globally, the user's
|
|
// cwd is not the package root, so a cwd-relative lookup returns null →
|
|
// "Could not determine current version".
|
|
test("getCurrentVersion resolves the real version from a foreign cwd (#3295)", async () => {
|
|
const originalCwd = process.cwd();
|
|
const foreignCwd = mkdtempSync(path.join(tmpdir(), "omniroute-cwd-"));
|
|
try {
|
|
process.chdir(foreignCwd); // no package.json here → cwd-relative lookup would fail
|
|
const version = await update.getCurrentVersion();
|
|
assert.equal(version, REAL_VERSION);
|
|
} finally {
|
|
process.chdir(originalCwd);
|
|
rmSync(foreignCwd, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
// #3295 issue 2: createBackup() must (a) resolve bin/ relative to the script,
|
|
// and (b) copy the "cli" directory recursively. The old copyFileSync(dir) threw
|
|
// EISDIR which the outer catch swallowed → "Failed to create backup. Aborting".
|
|
test("createBackup resolves bin/ from a foreign cwd and copies cli/ recursively (#3295)", async () => {
|
|
const originalCwd = process.cwd();
|
|
const originalHome = process.env.HOME;
|
|
const foreignCwd = mkdtempSync(path.join(tmpdir(), "omniroute-cwd-"));
|
|
const fakeHome = mkdtempSync(path.join(tmpdir(), "omniroute-home-"));
|
|
try {
|
|
process.chdir(foreignCwd); // no bin/ here → cwd-relative binPath would be missing
|
|
process.env.HOME = fakeHome; // redirect ~/.omniroute/backups
|
|
mkdirSync(fakeHome, { recursive: true });
|
|
|
|
const backupDir = await update.createBackup();
|
|
|
|
assert.ok(backupDir, "createBackup must return a path (not null)");
|
|
// omniroute.mjs is a real file in bin/ and must be copied
|
|
assert.ok(existsSync(path.join(backupDir, "omniroute.mjs")), "omniroute.mjs copied");
|
|
// "cli" is a directory — it must be copied recursively, not throw EISDIR
|
|
const cliBackup = path.join(backupDir, "cli");
|
|
assert.ok(existsSync(cliBackup), "cli/ directory copied");
|
|
assert.ok(statSync(cliBackup).isDirectory(), "cli/ backup is a directory");
|
|
assert.ok(existsSync(path.join(cliBackup, "commands")), "cli/ contents copied recursively");
|
|
} finally {
|
|
process.chdir(originalCwd);
|
|
if (originalHome === undefined) delete process.env.HOME;
|
|
else process.env.HOME = originalHome;
|
|
rmSync(foreignCwd, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
rmSync(fakeHome, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|