mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
47 lines
1.7 KiB
TypeScript
47 lines
1.7 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
|
|
const update = await import("../../bin/cli/commands/update.mjs");
|
|
|
|
test("runUpdateCommand claims success without verifying the running binary version changed (#9475)", async () => {
|
|
const fakeBin = mkdtempSync(path.join(tmpdir(), "omniroute-cli-update-9475-"));
|
|
writeFileSync(
|
|
path.join(fakeBin, "npm"),
|
|
`#!/usr/bin/env bash
|
|
if [ "$1" = "view" ]; then echo "3.8.99"; exit 0; fi
|
|
if [ "$1" = "install" ]; then echo "added 1 package"; exit 0; fi
|
|
exit 0
|
|
`,
|
|
{ mode: 0o755 }
|
|
);
|
|
|
|
const origPath = process.env.PATH;
|
|
process.env.PATH = fakeBin + path.delimiter + (origPath ?? "");
|
|
const stdoutLogs: string[] = [];
|
|
const origLog = console.log;
|
|
console.log = function (...args: unknown[]) {
|
|
stdoutLogs.push(args.map(String).join(" "));
|
|
};
|
|
try {
|
|
const exitCode = await update.runUpdateCommand({ yes: true, backup: false });
|
|
const realVersion = await update.getCurrentVersion();
|
|
const claimed = stdoutLogs.some((l) => /Updated to version 3\.8\.99/i.test(l));
|
|
if (claimed && exitCode === 0) {
|
|
assert.fail(
|
|
"runUpdateCommand claimed Updated to version 3.8.99 (exit 0) but the running binary is still " +
|
|
realVersion +
|
|
" — the resolved/shadowing install was not actually updated. Must re-verify getCurrentVersion() after install or warn the user."
|
|
);
|
|
}
|
|
assert.ok(true);
|
|
} finally {
|
|
console.log = origLog;
|
|
if (origPath === undefined) delete process.env.PATH;
|
|
else process.env.PATH = origPath;
|
|
rmSync(fakeBin, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|