mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
104 lines
3.9 KiB
TypeScript
104 lines
3.9 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { existsSync, readFileSync, mkdtempSync, rmSync } from "node:fs";
|
|
import { join } from "node:path";
|
|
import { tmpdir } from "node:os";
|
|
|
|
let tmpDir: string;
|
|
let origAppData: string | undefined;
|
|
|
|
test.before(() => {
|
|
tmpDir = mkdtempSync(join(tmpdir(), "omniroute-autostart-win-"));
|
|
origAppData = process.env.APPDATA;
|
|
process.env.APPDATA = tmpDir;
|
|
});
|
|
|
|
test.after(() => {
|
|
if (origAppData === undefined) delete process.env.APPDATA;
|
|
else process.env.APPDATA = origAppData;
|
|
try {
|
|
rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {}
|
|
});
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Integration test — runs only on win32 because enable() dispatches on
|
|
// process.platform. Sets APPDATA to a temp dir so the VBS is written to a
|
|
// clean, disposable Startup folder.
|
|
// ---------------------------------------------------------------------------
|
|
|
|
test("Windows enable/disable writes and removes VBS in Startup folder", async () => {
|
|
if (process.platform !== "win32") return;
|
|
|
|
const { enable, disable, isAutostartEnabled } =
|
|
await import("../../../bin/cli/tray/autostart.mjs");
|
|
|
|
const startupDir = join(tmpDir, "Microsoft", "Windows", "Start Menu", "Programs", "Startup");
|
|
const vbsPath = join(startupDir, "OmniRoute.vbs");
|
|
|
|
// Should start clean.
|
|
assert.equal(existsSync(vbsPath), false);
|
|
|
|
const ok = enable();
|
|
assert.equal(typeof ok, "boolean");
|
|
assert.equal(ok, true);
|
|
|
|
// VBS file must exist with correct content.
|
|
assert.equal(existsSync(vbsPath), true);
|
|
const vbs = readFileSync(vbsPath, "utf8");
|
|
assert.match(vbs, /WScript\.Shell/, "creates WScript.Shell COM object");
|
|
assert.match(vbs, /WshShell\.Run/, "calls Run method");
|
|
assert.match(vbs, /serve --no-open --tray/, "launches OmniRoute tray server");
|
|
assert.match(vbs, /, 0, False/, "uses SW_HIDE (0) and no wait");
|
|
assert.equal(vbs.endsWith("\n"), true, "trailing newline");
|
|
|
|
assert.equal(isAutostartEnabled(), true);
|
|
|
|
// Disable and verify cleanup.
|
|
const disabled = disable();
|
|
assert.equal(typeof disabled, "boolean");
|
|
assert.equal(disabled, true);
|
|
assert.equal(existsSync(vbsPath), false);
|
|
assert.equal(isAutostartEnabled(), false);
|
|
});
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Source-level assertions (run on any platform) — verify the implementation
|
|
// uses the VBS Startup-folder approach instead of the old Registry Run key.
|
|
// Mirrors the pattern used by autostart-linux.test.ts and
|
|
// autostart-macos-launchctl.test.ts.
|
|
// ---------------------------------------------------------------------------
|
|
|
|
test("Windows enableWin writes VBS to Startup folder, not reg add", () => {
|
|
const source = readFileSync(join(process.cwd(), "bin/cli/tray/autostart.mjs"), "utf8");
|
|
|
|
// Helper functions for the new VBS approach.
|
|
assert.match(source, /winStartupDir/);
|
|
assert.match(source, /winStartupPath/);
|
|
assert.match(source, /buildWinVbsContent/);
|
|
|
|
// VBS-runner scaffolding.
|
|
assert.match(source, /WScript\.Shell/);
|
|
assert.match(source, /WshShell\.Run/);
|
|
|
|
// The old approach used `reg add ... /v WIN_REG_VALUE`.
|
|
assert.doesNotMatch(source, /reg add.*WIN_REG_VALUE/);
|
|
});
|
|
|
|
test("Windows disableWin deletes VBS and cleans legacy registry", () => {
|
|
const source = readFileSync(join(process.cwd(), "bin/cli/tray/autostart.mjs"), "utf8");
|
|
|
|
assert.match(source, /unlinkSync\(vbsPath\)/);
|
|
assert.match(source, /cleanLegacyWinReg\(\)/);
|
|
});
|
|
|
|
test("Windows isEnabledWin checks VBS first, falls back to legacy reg", () => {
|
|
const source = readFileSync(join(process.cwd(), "bin/cli/tray/autostart.mjs"), "utf8");
|
|
|
|
// Primary check is VBS file existence.
|
|
assert.match(source, /existsSync\(vbsPath\)/);
|
|
|
|
// Fallback for users still on the old Registry Run key.
|
|
assert.match(source, /reg query.*WIN_REG_VALUE/);
|
|
});
|