Files
OmniRoute/tests/unit/cli/run-execution.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

171 lines
6.4 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import { chmod, mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
import { existsSync } from "node:fs";
import os from "node:os";
import path from "node:path";
import { runCliTarget } from "../../../bin/cli/commands/run.mjs";
const originalFetch = globalThis.fetch;
const originalPath = process.env.PATH;
async function makeFakeCli(name: string, body: string) {
const dir = await mkdtemp(path.join(os.tmpdir(), "omniroute-run-cli-"));
const file = path.join(dir, name);
await writeFile(file, `#!/usr/bin/env node\n${body}\n`, { mode: 0o755 });
await chmod(file, 0o755);
return { dir, file };
}
async function withReachableOmniRoute<T>(run: () => Promise<T>): Promise<T> {
globalThis.fetch = async () => new Response("{}", { status: 200 });
try {
return await run();
} finally {
globalThis.fetch = originalFetch;
}
}
test("run executes a generic target with isolated env and propagates its exit code", async (t) => {
if (process.platform === "win32") {
t.skip("POSIX fake executable; Windows shim behavior is covered by launch tests");
return;
}
const capture = await mkdtemp(path.join(os.tmpdir(), "omniroute-run-capture-"));
const capturePath = path.join(capture, "aider.json");
const fake = await makeFakeCli(
"aider",
`const fs = await import("node:fs");
fs.writeFileSync(process.env.CAPTURE_PATH, JSON.stringify({
argv: process.argv.slice(2),
base: process.env.OPENAI_API_BASE,
key: process.env.OPENAI_API_KEY,
}));
process.exit(7);`
);
process.env.PATH = `${fake.dir}${path.delimiter}${originalPath || ""}`;
process.env.CAPTURE_PATH = capturePath;
try {
const code = await withReachableOmniRoute(() =>
runCliTarget(
"aider",
{ remote: "https://relay.example.test", apiKey: "sk_private", model: "glm/glm-5.2" },
["--message", "reply OK"]
)
);
assert.equal(code, 7);
const result = JSON.parse(await readFile(capturePath, "utf8"));
assert.deepEqual(result.argv.slice(0, 2), ["--model", "openai/glm/glm-5.2"]);
assert.deepEqual(result.argv.slice(2), ["--message", "reply OK"]);
assert.equal(result.base, "https://relay.example.test");
assert.equal(result.key, "sk_private");
} finally {
if (originalPath === undefined) delete process.env.PATH;
else process.env.PATH = originalPath;
delete process.env.CAPTURE_PATH;
await rm(fake.dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
await rm(capture, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
});
test("run gives Gemini an isolated GEMINI_CLI_HOME forcing api-key auth and removes it", async (t) => {
if (process.platform === "win32") {
t.skip("POSIX fake executable; Windows shim behavior is covered by launch tests");
return;
}
const capture = await mkdtemp(path.join(os.tmpdir(), "omniroute-run-gemini-capture-"));
const capturePath = path.join(capture, "gemini.json");
const fake = await makeFakeCli(
"gemini",
`const fs = await import("node:fs");
const path = await import("node:path");
const home = process.env.GEMINI_CLI_HOME;
const settings = JSON.parse(fs.readFileSync(path.join(home, ".gemini", "settings.json"), "utf8"));
fs.writeFileSync(process.env.CAPTURE_PATH, JSON.stringify({
home,
argv: process.argv.slice(2),
baseUrl: process.env.GOOGLE_GEMINI_BASE_URL,
key: process.env.GEMINI_API_KEY,
defaultAuth: process.env.GEMINI_DEFAULT_AUTH_TYPE,
selectedType: settings.security?.auth?.selectedType,
}));`
);
process.env.PATH = `${fake.dir}${path.delimiter}${originalPath || ""}`;
process.env.CAPTURE_PATH = capturePath;
try {
const code = await withReachableOmniRoute(() =>
runCliTarget(
"gemini",
{ remote: "https://relay.example.test", apiKey: "sk_private", model: "glm/glm-5.2" },
["-p", "reply OK"]
)
);
assert.equal(code, 0);
const result = JSON.parse(await readFile(capturePath, "utf8"));
assert.deepEqual(result.argv, ["--model", "glm/glm-5.2", "-p", "reply OK"]);
assert.equal(result.baseUrl, "https://relay.example.test");
assert.equal(result.key, "sk_private");
assert.equal(result.defaultAuth, "gemini-api-key");
assert.equal(result.selectedType, "gemini-api-key");
assert.equal(existsSync(result.home), false);
} finally {
if (originalPath === undefined) delete process.env.PATH;
else process.env.PATH = originalPath;
delete process.env.CAPTURE_PATH;
await rm(fake.dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
await rm(capture, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
});
test("run gives Qwen an isolated temporary home and removes it after exit", async (t) => {
if (process.platform === "win32") {
t.skip("POSIX fake executable; Windows shim behavior is covered by launch tests");
return;
}
const capture = await mkdtemp(path.join(os.tmpdir(), "omniroute-run-qwen-capture-"));
const capturePath = path.join(capture, "qwen.json");
const fake = await makeFakeCli(
"qwen",
`const fs = await import("node:fs");
const path = await import("node:path");
const home = process.env.QWEN_HOME;
const settings = JSON.parse(fs.readFileSync(path.join(home, "settings.json"), "utf8"));
fs.writeFileSync(process.env.CAPTURE_PATH, JSON.stringify({
home,
argv: process.argv.slice(2),
model: settings.model?.name,
baseUrl: settings.model?.baseUrl,
}));`
);
process.env.PATH = `${fake.dir}${path.delimiter}${originalPath || ""}`;
process.env.CAPTURE_PATH = capturePath;
try {
const code = await withReachableOmniRoute(() =>
runCliTarget(
"qwen",
{ remote: "https://relay.example.test", apiKey: "sk_private", model: "glm/glm-5.2" },
["-p", "reply OK"]
)
);
assert.equal(code, 0);
const result = JSON.parse(await readFile(capturePath, "utf8"));
assert.deepEqual(result.argv, ["--model", "glm/glm-5.2", "-p", "reply OK"]);
assert.equal(result.model, "glm/glm-5.2");
assert.equal(result.baseUrl, "https://relay.example.test/v1");
assert.equal(existsSync(result.home), false);
} finally {
if (originalPath === undefined) delete process.env.PATH;
else process.env.PATH = originalPath;
delete process.env.CAPTURE_PATH;
await rm(fake.dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
await rm(capture, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
});