mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-15 19:32:20 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
60 lines
2.7 KiB
TypeScript
60 lines
2.7 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import fsp from "node:fs/promises";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// cliRuntime.ts computes EXPECTED_PARENT_PATHS from os.homedir() at MODULE LOAD
|
|
// time, so HOME must be redirected before the module is imported.
|
|
const sandboxHome = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-7753-home-"));
|
|
const outsideDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-7753-outside-"));
|
|
|
|
process.env.HOME = sandboxHome;
|
|
process.env.USERPROFILE = sandboxHome;
|
|
process.env.npm_config_prefix = path.join(sandboxHome, "npm-prefix-unused");
|
|
delete process.env.CLI_OPENCODE_BIN;
|
|
|
|
const localBinDir = path.join(sandboxHome, ".local", "bin");
|
|
fs.mkdirSync(localBinDir, { recursive: true });
|
|
|
|
const realBinaryPath = path.join(outsideDir, "opencode-real-binary");
|
|
fs.writeFileSync(realBinaryPath, "#!/bin/sh\necho fake-opencode-binary-body-padding\n");
|
|
fs.chmodSync(realBinaryPath, 0o755);
|
|
|
|
// symlink lives INSIDE a trusted parent (HOME/.local/bin) — like nvm-windows's
|
|
// opencode.cmd under AppData\Local\nvm\<ver>\ — but its resolved target is outside.
|
|
const symlinkPath = path.join(localBinDir, "opencode");
|
|
fs.symlinkSync(realBinaryPath, symlinkPath);
|
|
|
|
const { getCliRuntimeStatus, checkKnownPath } =
|
|
await import("../../src/shared/services/cliRuntime.ts");
|
|
|
|
test("#7753: a CLI symlink located inside an expected parent dir is wrongly reported not-installed when its resolved target escapes EXPECTED_PARENT_PATHS", async () => {
|
|
const status = await getCliRuntimeStatus("opencode");
|
|
assert.equal(
|
|
status.installed,
|
|
true,
|
|
`expected installed=true but got installed=${status.installed} reason=${status.reason}`
|
|
);
|
|
});
|
|
|
|
test("#7753: a genuinely unsafe symlink whose ORIGINAL location is also untrusted must still be rejected", async () => {
|
|
// Neither the symlink's own location nor its resolved target is inside any
|
|
// EXPECTED_PARENT_PATHS entry — this must stay rejected as symlink_escape.
|
|
const untrustedDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-7753-untrusted-"));
|
|
const untrustedSymlink = path.join(untrustedDir, "opencode");
|
|
fs.symlinkSync(realBinaryPath, untrustedSymlink);
|
|
|
|
const result = await checkKnownPath(untrustedSymlink);
|
|
assert.equal(result.installed, false);
|
|
assert.equal(result.reason, "symlink_escape");
|
|
|
|
await fsp.rm(untrustedDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test.after(async () => {
|
|
await fsp.rm(sandboxHome, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
await fsp.rm(outsideDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|