mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-10 17:02:22 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
82 lines
3.3 KiB
TypeScript
82 lines
3.3 KiB
TypeScript
/**
|
|
* Cloud-agent credentials CRUD + migration coverage.
|
|
*
|
|
* Release/v3.8.2 review finding: the `cloud_agent_credentials` table used to be
|
|
* created inline via `ensureCredentialsTable()` on every call (violating the
|
|
* versioned-migration policy). That inline DDL was removed in favor of
|
|
* migration `061_cloud_agent_credentials.sql`. These tests prove the table is
|
|
* provisioned by the normal DB-init migration run and that encrypt-at-rest
|
|
* CRUD still works end to end — with NO lazy table creation.
|
|
*/
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-cloud-agent-creds-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "cloud-agent-creds-test-secret";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const creds = await import("../../src/lib/cloudAgent/credentials.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("migration 061 provisions cloud_agent_credentials (table exists after DB init)", () => {
|
|
const db = core.getDbInstance();
|
|
const row = db
|
|
.prepare("SELECT name FROM sqlite_master WHERE type = 'table' AND name = ?")
|
|
.get("cloud_agent_credentials") as { name?: string } | undefined;
|
|
assert.equal(
|
|
row?.name,
|
|
"cloud_agent_credentials",
|
|
"table must be created by migration, not inline"
|
|
);
|
|
});
|
|
|
|
test("ensureCredentialsTable is no longer exported (inline DDL removed)", () => {
|
|
assert.equal(
|
|
(creds as Record<string, unknown>).ensureCredentialsTable,
|
|
undefined,
|
|
"lazy table creation must be gone — migration owns the schema"
|
|
);
|
|
});
|
|
|
|
test("save → get round-trips and decrypts the API key", () => {
|
|
creds.saveCloudAgentCredential("devin", "sk-secret-123", "https://api.devin.example");
|
|
const got = creds.getCloudAgentCredentialFromDb("devin");
|
|
assert.deepEqual(got, { apiKey: "sk-secret-123", baseUrl: "https://api.devin.example" });
|
|
});
|
|
|
|
test("get returns null for unknown provider", () => {
|
|
assert.equal(creds.getCloudAgentCredentialFromDb("does-not-exist"), null);
|
|
});
|
|
|
|
test("save upserts (ON CONFLICT) rather than duplicating", () => {
|
|
creds.saveCloudAgentCredential("jules", "sk-first");
|
|
creds.saveCloudAgentCredential("jules", "sk-second", "https://jules.example");
|
|
const got = creds.getCloudAgentCredentialFromDb("jules");
|
|
assert.deepEqual(got, { apiKey: "sk-second", baseUrl: "https://jules.example" });
|
|
});
|
|
|
|
test("list returns masked keys, never the plaintext", () => {
|
|
creds.saveCloudAgentCredential("codex-cloud", "sk-supersecretvalue");
|
|
const list = creds.listCloudAgentCredentials();
|
|
const entry = list.find((c) => c.providerId === "codex-cloud");
|
|
assert.ok(entry, "saved provider must appear in the list");
|
|
assert.equal(entry.apiKey, "****alue");
|
|
assert.ok(!entry.apiKey.includes("supersecret"), "plaintext key must never be returned");
|
|
});
|
|
|
|
test("delete removes the credential", () => {
|
|
creds.saveCloudAgentCredential("temp", "sk-temp");
|
|
assert.ok(creds.getCloudAgentCredentialFromDb("temp"));
|
|
creds.deleteCloudAgentCredential("temp");
|
|
assert.equal(creds.getCloudAgentCredentialFromDb("temp"), null);
|
|
});
|