mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-18 04:42:30 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
113 lines
3.9 KiB
TypeScript
113 lines
3.9 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// #4259: Cloudflare Workers AI `/ai/models/search` returns objects shaped like
|
|
// `{ id: "<uuid>", name: "@cf/meta/llama-3.1-8b-instruct" }` — the human-usable
|
|
// model identifier is `name`, while `id` is an internal UUID. Discovery must use
|
|
// `name` as the callable model id; otherwise the dashboard/import shows UUIDs.
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-cf-models-4259-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const providerModelsRoute = await import("../../src/app/api/providers/[id]/models/route.ts");
|
|
|
|
const originalFetch = globalThis.fetch;
|
|
|
|
async function resetStorage() {
|
|
globalThis.fetch = originalFetch;
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
async function seedConnection(provider: string, overrides: Record<string, any> = {}) {
|
|
return providersDb.createProviderConnection({
|
|
provider,
|
|
authType: overrides.authType || "apikey",
|
|
name: overrides.name || `${provider}-${Math.random().toString(16).slice(2, 8)}`,
|
|
apiKey: overrides.apiKey,
|
|
isActive: overrides.isActive ?? true,
|
|
testStatus: overrides.testStatus || "active",
|
|
providerSpecificData: overrides.providerSpecificData || {},
|
|
});
|
|
}
|
|
|
|
async function callRoute(connectionId: string, search = "") {
|
|
return providerModelsRoute.GET(
|
|
new Request(`http://localhost/api/providers/${connectionId}/models${search}`),
|
|
{ params: { id: connectionId } }
|
|
);
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(async () => {
|
|
globalThis.fetch = originalFetch;
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("#4259 cloudflare-ai discovery uses the model name (slug) as id, not the UUID", async () => {
|
|
const connection = await seedConnection("cloudflare-ai", {
|
|
apiKey: "cf-token",
|
|
providerSpecificData: { accountId: "acc-123" },
|
|
});
|
|
|
|
const LLAMA_UUID = "429b9e8b-d99e-44de-91ad-706cf8183658";
|
|
const QWEN_UUID = "f8703a00-ed54-4c83-bcd9-706cf8183999";
|
|
|
|
let calledUrl = "";
|
|
globalThis.fetch = (async (url: any) => {
|
|
calledUrl = String(url);
|
|
return Response.json({
|
|
result: [
|
|
{
|
|
id: LLAMA_UUID,
|
|
name: "@cf/meta/llama-3.1-8b-instruct",
|
|
description: "Llama 3.1 8B Instruct",
|
|
task: { name: "Text Generation" },
|
|
},
|
|
{
|
|
id: QWEN_UUID,
|
|
name: "@cf/qwen/qwen1.5-0.5b-chat",
|
|
description: "Qwen 1.5 0.5B Chat",
|
|
task: { name: "Text Generation" },
|
|
},
|
|
],
|
|
});
|
|
}) as typeof fetch;
|
|
|
|
const response = await callRoute(connection.id, "?refresh=true");
|
|
assert.equal(response.status, 200);
|
|
|
|
// Sanity: hit the Cloudflare models search endpoint with the configured account.
|
|
assert.ok(
|
|
calledUrl.includes("/accounts/acc-123/ai/models/search"),
|
|
`unexpected discovery URL: ${calledUrl}`
|
|
);
|
|
|
|
const body = await response.json();
|
|
assert.equal(body.source, "api");
|
|
const ids: string[] = body.models.map((m: any) => m.id);
|
|
|
|
// The human-usable slug must be the id (RED before the fix — id was the UUID).
|
|
assert.ok(
|
|
ids.includes("@cf/meta/llama-3.1-8b-instruct"),
|
|
`expected slug id, got ${JSON.stringify(ids)}`
|
|
);
|
|
assert.ok(
|
|
ids.includes("@cf/qwen/qwen1.5-0.5b-chat"),
|
|
`expected slug id, got ${JSON.stringify(ids)}`
|
|
);
|
|
// The internal UUID must never be exposed as a callable model id.
|
|
assert.ok(!ids.includes(LLAMA_UUID), "UUID must not be used as a model id");
|
|
assert.ok(!ids.includes(QWEN_UUID), "UUID must not be used as a model id");
|
|
});
|