Files
OmniRoute/tests/unit/codex-fingerprint-seed-persistence.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

112 lines
4.2 KiB
TypeScript

import { after, beforeEach, test } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-codex-seed-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const UUID_V4_PATTERN = /^[0-9a-f]{8}-[0-9a-f]{4}-4[0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/;
async function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
beforeEach(resetStorage);
after(() => {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
async function createCodexOAuthConnection(providerSpecificData?: Record<string, unknown>) {
const suffix = Math.random().toString(16).slice(2, 10);
const connection = await providersDb.createProviderConnection({
provider: "codex",
authType: "oauth",
name: `codex-${suffix}`,
accessToken: `access-${suffix}`,
refreshToken: `refresh-${suffix}`,
providerSpecificData,
});
assert.ok(connection && typeof connection.id === "string");
return connection;
}
test("codex OAuth connections persist a fingerprint seed at creation (default session mode)", async () => {
const connection = await createCodexOAuthConnection();
const psd = connection.providerSpecificData as Record<string, unknown>;
assert.match(String(psd.codexFingerprintSeed), UUID_V4_PATTERN);
});
test("the seed survives unrelated edits and explicit re-saves (identity stability)", async () => {
const connection = await createCodexOAuthConnection({ workspaceId: "ws-1" });
const seed = (connection.providerSpecificData as Record<string, unknown>).codexFingerprintSeed;
const renamed = await providersDb.updateProviderConnection(connection.id, { name: "renamed" });
assert.equal(
(renamed?.providerSpecificData as Record<string, unknown>).codexFingerprintSeed,
seed
);
const resaved = await providersDb.updateProviderConnection(connection.id, {
providerSpecificData: { workspaceId: "ws-1", codexFingerprintMode: "full" },
});
assert.equal(
(resaved?.providerSpecificData as Record<string, unknown>).codexFingerprintSeed,
seed
);
assert.equal(
(resaved?.providerSpecificData as Record<string, unknown>).codexFingerprintMode,
"full"
);
});
test("explicit off is not seeded; switching to full seeds once and keeps it", async () => {
const connection = await createCodexOAuthConnection({ codexFingerprintMode: "off" });
assert.equal(
(connection.providerSpecificData as Record<string, unknown>).codexFingerprintSeed,
undefined
);
const switched = await providersDb.updateProviderConnection(connection.id, {
providerSpecificData: { codexFingerprintMode: "full" },
});
const psd = switched?.providerSpecificData as Record<string, unknown>;
assert.match(String(psd.codexFingerprintSeed), UUID_V4_PATTERN);
const again = await providersDb.updateProviderConnection(connection.id, { name: "again" });
assert.equal(
(again?.providerSpecificData as Record<string, unknown>).codexFingerprintSeed,
psd.codexFingerprintSeed
);
});
test("a client-supplied seed is replaced by a system-managed one", async () => {
const connection = await createCodexOAuthConnection({
codexFingerprintSeed: "client-supplied-not-a-uuid",
});
const seed = String(
(connection.providerSpecificData as Record<string, unknown>).codexFingerprintSeed
);
assert.match(seed, UUID_V4_PATTERN);
assert.notEqual(seed, "client-supplied-not-a-uuid");
});
test("non-OAuth codex connections are never seeded", async () => {
const suffix = Math.random().toString(16).slice(2, 10);
const connection = await providersDb.createProviderConnection({
provider: "codex",
authType: "apikey",
name: `codex-key-${suffix}`,
apiKey: `sk-codex-${suffix}`,
});
assert.ok(connection);
const psd = (connection.providerSpecificData ?? {}) as Record<string, unknown>;
assert.equal(psd.codexFingerprintSeed, undefined);
});