mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-16 03:42:21 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
72 lines
3.1 KiB
TypeScript
72 lines
3.1 KiB
TypeScript
/**
|
|
* Issue #2877 — two routing/effort defects for the gpt-5.5 Codex family:
|
|
*
|
|
* (B) `gpt-5.5-xhigh` (and -high/-low) misrouted to the `openai` provider
|
|
* because only bare `gpt-5.5` was in CODEX_PREFERRED_UNPREFIXED_MODELS — the
|
|
* suffixed variants fell through to the `/^gpt-/` → openai fallback, so a
|
|
* Codex-OAuth-only user got "No credentials for provider: openai". Fixed by
|
|
* adding the variants to the set (`open-sse/services/model.ts`).
|
|
*
|
|
* (A) For a Codex-only account, a bare `gpt-5.5` Responses request was rerouted
|
|
* to codex but with the model hardcoded to `gpt-5.5-medium`
|
|
* (`src/sse/handlers/chatHelpers.ts`). The Codex executor reads that `-medium`
|
|
* suffix as an explicit `modelEffort`, which (per #2331) overrides the
|
|
* client's `reasoning.effort=xhigh` — silently demoting it. Fixed by keeping
|
|
* the bare `gpt-5.5` id; the executor's modelEffort-first precedence (#2331)
|
|
* is left untouched.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-gpt55-routing-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const { getModelInfoCore } = await import("../../open-sse/services/model.ts");
|
|
const { resolveModelOrError } = await import("../../src/sse/handlers/chatHelpers.ts");
|
|
|
|
test.before(async () => {
|
|
// Codex-only active account (no openai connection).
|
|
await providersDb.createProviderConnection({
|
|
provider: "codex",
|
|
authType: "oauth",
|
|
email: "codex@example.com",
|
|
providerSpecificData: { workspaceId: "ws-1" },
|
|
});
|
|
});
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
// ── Defect B: suffixed bare names infer codex, not openai ─────────────────────
|
|
for (const variant of ["gpt-5.5-xhigh", "gpt-5.5-high", "gpt-5.5-low"]) {
|
|
test(`#2877(B) ${variant} infers codex (not openai)`, async () => {
|
|
const info = await getModelInfoCore(variant, null);
|
|
assert.equal(info.provider, "codex", `${variant} must infer the codex provider`);
|
|
assert.equal(info.model, variant, "the explicit effort suffix must be preserved");
|
|
});
|
|
}
|
|
|
|
// ── Defect A: Codex-only bare gpt-5.5 reroute must NOT bake a -medium suffix ───
|
|
test("#2877(A) Codex-only bare gpt-5.5 Responses request keeps the bare model id", async () => {
|
|
const result = (await resolveModelOrError(
|
|
"gpt-5.5",
|
|
{ input: [{ role: "user", content: [{ type: "input_text", text: "hi" }] }] },
|
|
"/v1/responses",
|
|
null
|
|
)) as { provider?: string; model?: string };
|
|
|
|
assert.equal(result.provider, "codex", "Codex-only account must reroute gpt-5.5 to codex");
|
|
assert.equal(
|
|
result.model,
|
|
"gpt-5.5",
|
|
"must NOT inject a -medium suffix (that would override a client reasoning.effort=xhigh)"
|
|
);
|
|
});
|