mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-21 22:32:22 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
80 lines
2.9 KiB
TypeScript
80 lines
2.9 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-codex-3317-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const { CodexExecutor } = await import("../../open-sse/executors/codex.ts");
|
|
|
|
// #3317: a /v1/responses request against the built-in codex/ provider does an
|
|
// openai-responses -> openai-responses passthrough. The Codex upstream rejects
|
|
// client-only fields with 400 "Unsupported parameter": prompt_cache_retention,
|
|
// safety_identifier, user. The chat-completions path strips them, but the
|
|
// native passthrough (transformRequest returns body early) did not.
|
|
test("codex native responses passthrough strips client-only params (#3317)", async () => {
|
|
const executor = new CodexExecutor();
|
|
const body = {
|
|
_nativeCodexPassthrough: true,
|
|
model: "gpt-5.5",
|
|
input: [{ role: "user", content: [{ type: "input_text", text: "reply ok" }] }],
|
|
prompt_cache_retention: "24h",
|
|
safety_identifier: "droid-user-123",
|
|
user: "user-abc",
|
|
max_output_tokens: 16,
|
|
};
|
|
|
|
const result = (await executor.transformRequest("gpt-5.5", body, false, {} as never)) as Record<
|
|
string,
|
|
unknown
|
|
>;
|
|
|
|
assert.equal(result.prompt_cache_retention, undefined, "prompt_cache_retention must be stripped");
|
|
assert.equal(result.safety_identifier, undefined, "safety_identifier must be stripped");
|
|
assert.equal(result.user, undefined, "user must be stripped");
|
|
// The real request payload must survive the strip.
|
|
assert.ok(Array.isArray(result.input), "input array preserved");
|
|
});
|
|
|
|
test("codex native responses passthrough normalizes additional_tools items", async () => {
|
|
const executor = new CodexExecutor();
|
|
const messageContent = [{ type: "input_text", text: "run the terminal tool" }];
|
|
const tools = [{ type: "function", name: "terminal", parameters: { type: "object" } }];
|
|
const body = {
|
|
_nativeCodexPassthrough: true,
|
|
model: "gpt-5.5",
|
|
input: [
|
|
{
|
|
type: "additional_tools",
|
|
role: "developer",
|
|
content: [{ type: "input_text", text: "unsupported wrapper content" }],
|
|
tools,
|
|
},
|
|
{ type: "message", role: "user", content: messageContent },
|
|
],
|
|
};
|
|
|
|
const result = (await executor.transformRequest("gpt-5.5", body, true, {} as never)) as {
|
|
input: Array<Record<string, unknown>>;
|
|
};
|
|
|
|
assert.deepEqual(result.input[0], { type: "additional_tools", role: "developer", tools });
|
|
assert.deepEqual(result.input[1], { type: "message", role: "user", content: messageContent });
|
|
});
|
|
|
|
test.after(() => {
|
|
try {
|
|
core.resetDbInstance?.();
|
|
} catch {
|
|
/* ignore */
|
|
}
|
|
try {
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {
|
|
/* ignore */
|
|
}
|
|
});
|