Files
OmniRoute/tests/unit/codex-responses-to-chat-9161.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

68 lines
2.2 KiB
TypeScript

import assert from "node:assert/strict";
import test from "node:test";
import { resolveChatCoreTargetFormat } from "../../open-sse/handlers/chatCore/targetFormat.ts";
import { sanitizeChatRequestBody } from "../../open-sse/handlers/chatCore/sanitization.ts";
import { FORMATS } from "../../open-sse/translator/formats.ts";
test("#9161 Responses client honors a custom OpenAI-compatible Chat target", () => {
const result = resolveChatCoreTargetFormat({
provider: "openai-compatible-chat-regression",
resolvedModel: "custom-chat-model",
apiFormat: "responses",
sourceFormat: FORMATS.OPENAI_RESPONSES,
customModelTargetFormat: undefined,
providerSpecificData: { apiType: "chat" },
});
assert.equal(result.targetFormat, FORMATS.OPENAI);
});
test("#9161 Responses client preserves a custom OpenAI-compatible Responses target", () => {
const result = resolveChatCoreTargetFormat({
provider: "openai-compatible-responses-regression",
resolvedModel: "custom-responses-model",
apiFormat: "responses",
sourceFormat: FORMATS.OPENAI_RESPONSES,
customModelTargetFormat: undefined,
providerSpecificData: { apiType: "responses" },
});
assert.equal(result.targetFormat, FORMATS.OPENAI_RESPONSES);
});
test("#9161 official OpenAI keeps Responses routing for the Responses API", () => {
const result = resolveChatCoreTargetFormat({
provider: "openai",
resolvedModel: "gpt-4o",
apiFormat: "responses",
sourceFormat: FORMATS.OPENAI_RESPONSES,
customModelTargetFormat: undefined,
providerSpecificData: undefined,
});
assert.equal(result.targetFormat, FORMATS.OPENAI_RESPONSES);
});
test("#9161 Responses source targeting Chat converts max_output_tokens to max_tokens", () => {
const body = sanitizeChatRequestBody(
{ max_output_tokens: 256 },
FORMATS.OPENAI_RESPONSES,
FORMATS.OPENAI
);
assert.equal(body.max_tokens, 256);
assert.equal(body.max_output_tokens, undefined);
});
test("#9161 Responses target keeps the Responses token field", () => {
const body = sanitizeChatRequestBody(
{ max_tokens: 128 },
FORMATS.OPENAI,
FORMATS.OPENAI_RESPONSES
);
assert.equal(body.max_output_tokens, 128);
assert.equal(body.max_tokens, undefined);
});