Files
OmniRoute/tests/unit/combo-context-generic-default-10734.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

107 lines
4.0 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-10734-combo-ctx-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET ||= "combo-context-10734-secret";
const { getSourcedTokenLimit, resolveTokenLimit, getTokenLimit } =
await import("../../open-sse/services/contextManager.ts");
const { computeComboContextLength } = await import("../../src/lib/combos/comboContext.ts");
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const combosDb = await import("../../src/lib/db/combos.ts");
const contextOverrides = await import("../../src/lib/db/modelContextOverrides.ts");
const catalog = await import("../../src/app/api/v1/models/catalog.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("#10734: resolveTokenLimit marks the generic 128k catch-all as specific:false", () => {
const resolved = resolveTokenLimit("not-a-real-provider", "no-such-model");
assert.equal(resolved.limit, 128000);
assert.equal(resolved.specific, false);
});
test("#10734: getSourcedTokenLimit omits the generic 128k catch-all", () => {
assert.equal(getSourcedTokenLimit("not-a-real-provider", "no-such-model"), undefined);
assert.equal(getTokenLimit("not-a-real-provider", "no-such-model"), 128000);
});
test("#10734: getSourcedTokenLimit keeps an explicit canonical window", () => {
assert.equal(getSourcedTokenLimit("not-a-real-provider", "no-such-model", 500000), 500000);
});
test("#10734: getSourcedTokenLimit keeps provider-specific defaults (claude)", () => {
const sourced = getSourcedTokenLimit("claude", "claude-sonnet-4");
assert.equal(typeof sourced, "number");
assert.ok(sourced && sourced > 128000);
assert.equal(resolveTokenLimit("claude", "claude-sonnet-4").specific, true);
});
test("#10734: combo min() ignores unsourced members instead of advertising 128k", () => {
const combo = {
name: "large-plus-unknown",
models: ["glm/glm-5.2", "not-a-real-provider/no-such-model"],
};
const result = computeComboContextLength(combo, []);
assert.equal(
result,
1000000,
"glm-5.2 is a sourced 1M window; the generic-default member must not pull min() to 128k"
);
});
test("#10734: nested combo-ref inherits sourced min(), not 128k", () => {
const inner = {
name: "inner-large",
models: ["glm/glm-5.2", "not-a-real-provider/no-such-model"],
};
const wrapper = {
name: "wrapper-large",
models: [{ kind: "combo-ref", comboName: "inner-large" }],
};
const result = computeComboContextLength(wrapper, [inner, wrapper]);
assert.equal(result, 1000000);
});
test("#10734: GET /v1/models does not advertise 128k for a 500k combo plus an unsourced member", async () => {
const modelId = "gpt-5.6-terra";
assert.equal(contextOverrides.setModelContextOverride("codex", modelId, 500000), true);
await providersDb.createProviderConnection({
provider: "codex",
authType: "oauth",
name: "codex-10734-large-window",
accessToken: "codex-test-token",
isActive: true,
testStatus: "active",
providerSpecificData: {},
});
await combosDb.createCombo({
name: "large-context-combo-10734",
strategy: "priority",
models: [`codex/${modelId}`, "not-a-real-provider/no-such-model"],
});
const response = await catalog.getUnifiedModelsResponse(
new Request("http://localhost/api/v1/models")
);
const body = (await response.json()) as { data: Array<Record<string, unknown>> };
const combo = body.data.find((item) => item.id === "large-context-combo-10734");
assert.equal(response.status, 200);
assert.ok(combo, "combo should be published in /v1/models");
assert.notEqual(
combo.context_length,
128000,
"generic 128k must not win min() over the 500k sourced member"
);
assert.equal(combo.context_length, 500000);
});