mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
91 lines
3.3 KiB
TypeScript
91 lines
3.3 KiB
TypeScript
/**
|
|
* #5005 — Per-combo editable `description` field.
|
|
*
|
|
* The routing-combo API historically had NO `description` field: the Zod
|
|
* `createComboSchema` / `updateComboSchema` stripped any `description` on save.
|
|
* This proves the schema now ACCEPTS and PRESERVES `description`, and that the
|
|
* value round-trips through the DB layer (persisted in the `data` JSON blob and
|
|
* surfaced back by GET-style reads), with no new DB column.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-combo-desc-5005-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const { createComboSchema, updateComboSchema } =
|
|
await import("../../src/shared/validation/schemas.ts");
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const combosDb = await import("../../src/lib/db/combos.ts");
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
if (fs.existsSync(TEST_DATA_DIR)) {
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(async () => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("createComboSchema preserves description instead of stripping it", () => {
|
|
const parsed = createComboSchema.parse({
|
|
name: "Described Combo",
|
|
models: [{ provider: "openai", model: "gpt-4.1" }],
|
|
description: "Routes premium traffic to GPT-4.1",
|
|
});
|
|
assert.equal(parsed.description, "Routes premium traffic to GPT-4.1");
|
|
});
|
|
|
|
test("updateComboSchema preserves description instead of stripping it", () => {
|
|
const parsed = updateComboSchema.parse({
|
|
description: "Updated description text",
|
|
});
|
|
assert.equal(parsed.description, "Updated description text");
|
|
});
|
|
|
|
test("description round-trips through createCombo and getComboById/getComboByName", async () => {
|
|
const created = await combosDb.createCombo({
|
|
name: "Desc Combo",
|
|
models: [{ provider: "openai", model: "gpt-4.1" }],
|
|
description: "My human-friendly note",
|
|
});
|
|
assert.equal(created.description, "My human-friendly note");
|
|
|
|
const byId = await combosDb.getComboById(created.id as string);
|
|
assert.ok(byId, "combo should be retrievable by id");
|
|
assert.equal(byId!.description, "My human-friendly note");
|
|
|
|
const byName = await combosDb.getComboByName("Desc Combo");
|
|
assert.ok(byName, "combo should be retrievable by name");
|
|
assert.equal(byName!.description, "My human-friendly note");
|
|
});
|
|
|
|
test("description survives an updateCombo and is listed by getCombos", async () => {
|
|
const created = await combosDb.createCombo({
|
|
name: "Update Desc Combo",
|
|
models: [{ provider: "openai", model: "gpt-4.1" }],
|
|
});
|
|
|
|
const updated = await combosDb.updateCombo(created.id as string, {
|
|
description: "Added later via PUT",
|
|
});
|
|
assert.ok(updated);
|
|
assert.equal(updated!.description, "Added later via PUT");
|
|
|
|
const all = await combosDb.getCombos();
|
|
const found = all.find((c) => c.id === created.id);
|
|
assert.ok(found, "updated combo should appear in getCombos");
|
|
assert.equal(found!.description, "Added later via PUT");
|
|
});
|