mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-10 17:02:22 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
59 lines
1.9 KiB
TypeScript
59 lines
1.9 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-combo-patch-verb-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const combosDb = await import("../../src/lib/db/combos.ts");
|
|
const comboRoute = await import("../../src/app/api/combos/[id]/route.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
function patch(id: string, body: Record<string, unknown>) {
|
|
return new Request(`http://localhost/api/combos/${id}`, {
|
|
method: "PATCH",
|
|
headers: { "content-type": "application/json" },
|
|
body: JSON.stringify(body),
|
|
});
|
|
}
|
|
|
|
test("PATCH changes one field and leaves the rest of the combo alone", async () => {
|
|
const combo = await combosDb.createCombo({
|
|
name: "patchable",
|
|
strategy: "priority",
|
|
models: [{ provider: "openai", model: "gpt-4o" }],
|
|
system_message: "keep me",
|
|
});
|
|
|
|
const response = await comboRoute.PATCH(patch(combo.id, { strategy: "round-robin" }), {
|
|
params: Promise.resolve({ id: combo.id }),
|
|
});
|
|
assert.equal(response.status, 200);
|
|
|
|
const stored = (await combosDb.getComboById(combo.id)) as {
|
|
strategy?: string;
|
|
system_message?: string;
|
|
models?: unknown[];
|
|
};
|
|
assert.equal(stored.strategy, "round-robin");
|
|
assert.equal(stored.system_message, "keep me");
|
|
assert.equal(stored.models?.length, 1);
|
|
});
|
|
|
|
test("PATCH on an unknown combo answers 404, like PUT", async () => {
|
|
const response = await comboRoute.PATCH(patch("does-not-exist", { strategy: "priority" }), {
|
|
params: Promise.resolve({ id: "does-not-exist" }),
|
|
});
|
|
assert.equal(response.status, 404);
|
|
|
|
const body = (await response.json()) as { error?: { code?: string } };
|
|
assert.equal(body.error?.code, "COMBO_007");
|
|
});
|