mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
63 lines
2.5 KiB
TypeScript
63 lines
2.5 KiB
TypeScript
import { describe, it, beforeEach, afterEach, after } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
import { rtkConfigSchema } from "../../../src/shared/validation/compressionConfigSchemas.ts";
|
|
import { DEFAULT_RTK_CONFIG } from "../../../open-sse/services/compression/types.ts";
|
|
|
|
// The RTK R5 grouping feature is read by the engine (config.enableGrouping / groupingThreshold)
|
|
// but was unreachable in production: the Zod schema (.strict()) rejected the two fields on write
|
|
// and normalizeRtkConfig dropped them on read. This proves both gates now let them through.
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-rtk-grouping-"));
|
|
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../../src/lib/db/core.ts");
|
|
const { getCompressionSettings, updateCompressionSettings } =
|
|
await import("../../../src/lib/db/compression.ts");
|
|
|
|
describe("RTK grouping config persistence (R5)", () => {
|
|
beforeEach(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
});
|
|
|
|
afterEach(() => {
|
|
core.resetDbInstance();
|
|
});
|
|
|
|
after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
if (ORIGINAL_DATA_DIR === undefined) delete process.env.DATA_DIR;
|
|
else process.env.DATA_DIR = ORIGINAL_DATA_DIR;
|
|
});
|
|
|
|
it("accepts enableGrouping / groupingThreshold on the write schema", () => {
|
|
assert.equal(
|
|
rtkConfigSchema.safeParse({ enableGrouping: true, groupingThreshold: 5 }).success,
|
|
true
|
|
);
|
|
// groupingThreshold below the minimum run length (2) is rejected.
|
|
assert.equal(rtkConfigSchema.safeParse({ groupingThreshold: 1 }).success, false);
|
|
});
|
|
|
|
it("preserves enableGrouping / groupingThreshold through a DB round-trip", async () => {
|
|
const settings = await updateCompressionSettings({
|
|
rtkConfig: { ...DEFAULT_RTK_CONFIG, enableGrouping: true, groupingThreshold: 7 },
|
|
});
|
|
assert.equal(settings.rtkConfig.enableGrouping, true);
|
|
assert.equal(settings.rtkConfig.groupingThreshold, 7);
|
|
|
|
// Survives a fresh read (not just the write-path return value).
|
|
core.resetDbInstance();
|
|
const reread = await getCompressionSettings();
|
|
assert.equal(reread.rtkConfig.enableGrouping, true);
|
|
assert.equal(reread.rtkConfig.groupingThreshold, 7);
|
|
});
|
|
});
|