Files
OmniRoute/tests/unit/compression/rtk-raw-output-route.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

139 lines
4.8 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { makeManagementSessionRequest } from "../../helpers/managementSession.ts";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-rtk-raw-route-"));
const originalDataDir = process.env.DATA_DIR;
const originalJwtSecret = process.env.JWT_SECRET;
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../../src/lib/db/core.ts");
const settingsDb = await import("../../../src/lib/db/settings.ts");
const route = await import("../../../src/app/api/context/rtk/raw-output/[id]/route.ts");
const rawOutput = await import("../../../open-sse/services/compression/engines/rtk/rawOutput.ts");
type ErrorResponseBody = {
error: string | { message?: string };
};
async function resetAuthRequiredStorage(): Promise<void> {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
await settingsDb.updateSettings({
requireLogin: true,
setupComplete: true,
password: "test-password-hash",
});
}
test.beforeEach(async () => {
process.env.DATA_DIR = TEST_DATA_DIR;
await resetAuthRequiredStorage();
});
test.after(() => {
if (originalDataDir === undefined) delete process.env.DATA_DIR;
else process.env.DATA_DIR = originalDataDir;
if (originalJwtSecret === undefined) delete process.env.JWT_SECRET;
else process.env.JWT_SECRET = originalJwtSecret;
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("RTK raw-output route requires management auth before reading retained output", async () => {
const pointer = rawOutput.maybePersistRtkRawOutput("error: full output", {
retention: "always",
command: "pytest",
});
assert.ok(pointer);
const response = await route.GET(
new Request(`http://localhost/api/context/rtk/raw-output/${pointer.id}`),
{ params: Promise.resolve({ id: pointer.id }) }
);
const body = (await response.json()) as ErrorResponseBody;
assert.equal(response.status, 401);
assert.equal(
typeof body.error === "object" ? body.error.message : null,
"Authentication required"
);
});
test("RTK raw-output route rejects bearer tokens without a dashboard session", async () => {
const response = await route.GET(
new Request("http://localhost/api/context/rtk/raw-output/0123456789abcdef01234567", {
headers: { authorization: "Bearer invalid-management-token" },
}),
{ params: Promise.resolve({ id: "0123456789abcdef01234567" }) }
);
const body = (await response.json()) as ErrorResponseBody;
assert.equal(response.status, 403);
assert.equal(
typeof body.error === "object" ? body.error.message : null,
"Invalid management token"
);
});
test("RTK raw-output route validates pointer ids for authenticated callers", async () => {
const request = await makeManagementSessionRequest(
"http://localhost/api/context/rtk/raw-output/not-a-pointer"
);
const response = await route.GET(request, {
params: Promise.resolve({ id: "not-a-pointer" }),
});
const body = (await response.json()) as ErrorResponseBody;
assert.equal(response.status, 400);
assert.equal(body.error, "Invalid raw output id");
});
test("RTK raw-output route returns 404 for missing authenticated pointers", async () => {
const request = await makeManagementSessionRequest(
"http://localhost/api/context/rtk/raw-output/0123456789abcdef01234567"
);
const response = await route.GET(request, {
params: Promise.resolve({ id: "0123456789abcdef01234567" }),
});
const body = (await response.json()) as ErrorResponseBody;
assert.equal(response.status, 404);
assert.equal(body.error, "Raw output not found");
});
test("RTK raw-output route returns retained redacted output for authenticated callers", async () => {
const pointer = rawOutput.maybePersistRtkRawOutput(
"token=secret-value\nAuthorization: Bearer abcdef123456\nerror: full output",
{
retention: "always",
command: "pytest",
}
);
assert.ok(pointer);
const request = await makeManagementSessionRequest(
`http://localhost/api/context/rtk/raw-output/${pointer.id}`
);
const response = await route.GET(request, {
params: Promise.resolve({ id: pointer.id }),
});
const content = await response.text();
assert.equal(response.status, 200);
assert.equal(response.headers.get("cache-control"), "no-store");
assert.match(response.headers.get("content-type") ?? "", /text\/plain/);
assert.match(content, /token=\[REDACTED\]/);
assert.match(content, /Authorization: Bearer \[REDACTED\]/);
assert.ok(!content.includes("secret-value"));
assert.ok(!content.includes("abcdef123456"));
});