Files
OmniRoute/tests/unit/conductor-ask-route.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

89 lines
3.1 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { createServer, type Server } from "node:http";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-conductor-ask-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const askRoute = await import("../../src/app/api/conductor/ask/route.ts");
const servers: Server[] = [];
test.beforeEach(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
delete process.env.CONDUCTOR_SPOKESPERSON_URL;
});
test.after(async () => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
delete process.env.CONDUCTOR_SPOKESPERSON_URL;
while (servers.length > 0) {
const s = servers.pop();
await new Promise((resolve) => s?.close(resolve));
}
});
test("fonte: auth antes do proxy; token nunca manuseado na rota", () => {
const src = fs.readFileSync(
path.join(process.cwd(), "src/app/api/conductor/ask/route.ts"),
"utf8"
);
const authAt = src.indexOf("requireManagementAuth(");
assert.ok(authAt > 0);
assert.match(src, /if \(authError\) return authError;/);
assert.ok(src.indexOf("askFaro(") > authAt, "askFaro só depois do gate");
assert.ok(!src.includes("CONDUCTOR_HUB_TOKEN"), "token vive no faroProxy, não na rota");
});
test("POST valida o body (Zod) e repassa text+pending do Faro", async () => {
await new Promise<void>((resolve) => {
const server = createServer((req, res) => {
res.writeHead(200, { "content-type": "application/json" });
res.end(JSON.stringify({ text: "frota vazia", pending: null }));
});
servers.push(server);
server.listen(0, "127.0.0.1", () => {
const addr = server.address();
process.env.CONDUCTOR_SPOKESPERSON_URL = `http://127.0.0.1:${typeof addr === "object" && addr ? addr.port : 0}`;
resolve();
});
});
const ok = await askRoute.POST(
new Request("http://localhost/api/conductor/ask", {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify({ message: "como está a frota?" }),
})
);
assert.equal(ok.status, 200);
assert.deepEqual(await ok.json(), { text: "frota vazia", pending: null });
const bad = await askRoute.POST(
new Request("http://localhost/api/conductor/ask", {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify({ message: "" }),
})
);
assert.equal(bad.status, 400, "mensagem vazia é rejeitada pelo Zod");
});
test("Faro fora do ar → 503 sanitizado", async () => {
process.env.CONDUCTOR_SPOKESPERSON_URL = "http://127.0.0.1:1";
const res = await askRoute.POST(
new Request("http://localhost/api/conductor/ask", {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify({ message: "oi" }),
})
);
assert.equal(res.status, 503);
});