Files
OmniRoute/tests/unit/config-hot-reload.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

198 lines
7.3 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-config-hot-reload-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.OMNIROUTE_CONFIG_HOT_RELOAD_MS = "100";
const core = await import("../../src/lib/db/core.ts");
const settingsDb = await import("../../src/lib/db/settings.ts");
const { getDbInstance } = core;
const runtimeSettings = await import("../../src/lib/config/runtimeSettings.ts");
const { applyRuntimeSettings, resetRuntimeSettingsStateForTests } = runtimeSettings;
const { startRuntimeConfigHotReload, stopRuntimeConfigHotReloadForTests } =
await import("../../src/lib/config/hotReload.ts");
const { getCliCompatProviders } = await import("../../open-sse/config/cliFingerprints.ts");
const { getCustomAliases, setCustomAliases } =
await import("../../open-sse/services/modelDeprecation.ts");
const {
getBackgroundDegradationConfig,
getDefaultDegradationMap,
getDefaultDetectionPatterns,
setBackgroundDegradationConfig,
} = await import("../../open-sse/services/backgroundTaskDetector.ts");
const { clearGeminiThoughtSignatures, getGeminiThoughtSignatureMode } =
await import("../../open-sse/services/geminiThoughtSignatureStore.ts");
const { getPayloadRulesConfig, resetPayloadRulesConfigForTests } =
await import("../../open-sse/services/payloadRules.ts");
const { getCacheControlSettings, invalidateCacheControlSettingsCache } =
await import("../../src/lib/cacheControlSettings.ts");
const { getSyncStatus, stopPeriodicSync } = await import("../../src/lib/modelsDevSync.ts");
async function resetStorage() {
stopRuntimeConfigHotReloadForTests();
resetRuntimeSettingsStateForTests();
resetPayloadRulesConfigForTests();
clearGeminiThoughtSignatures();
setCustomAliases({});
setBackgroundDegradationConfig({
enabled: false,
degradationMap: getDefaultDegradationMap(),
detectionPatterns: getDefaultDetectionPatterns(),
});
invalidateCacheControlSettingsCache();
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
async function waitFor(check: () => Promise<boolean> | boolean, timeoutMs = 3000) {
const deadline = Date.now() + timeoutMs;
while (Date.now() < deadline) {
if (await check()) return;
await new Promise((resolve) => setTimeout(resolve, 50));
}
assert.fail("Timed out waiting for hot-reload condition");
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(async () => {
await resetStorage();
});
test("runtime settings public surface excludes removed snapshot inspection helper", () => {
assert.equal(
Object.hasOwn(runtimeSettings, "getLastAppliedRuntimeSettingsSnapshotForTests"),
false
);
assert.equal(typeof runtimeSettings.applyRuntimeSettings, "function");
assert.equal(typeof runtimeSettings.getAuthzBypassSnapshot, "function");
assert.equal(typeof runtimeSettings.resetRuntimeSettingsStateForTests, "function");
});
test("updateSettings applies runtime settings incrementally without restart", async () => {
await applyRuntimeSettings(await settingsDb.getSettings(), {
force: true,
source: "test:startup",
});
await settingsDb.updateSettings({
cliCompatProviders: ["OpenAI", "claude", "copilot"],
modelAliases: JSON.stringify({ "team-default": "openai/gpt-4o-mini" }),
backgroundDegradation: {
enabled: true,
degradationMap: { "gpt-4o": "gpt-4o-mini" },
detectionPatterns: ["summarize this"],
},
payloadRules: {
override: [
{
models: [{ name: "gpt-*", protocol: "openai" }],
params: { temperature: 0.1 },
},
],
},
alwaysPreserveClientCache: "always",
antigravitySignatureCacheMode: "bypass",
});
assert.deepEqual(getCliCompatProviders().sort(), ["claude", "github"]);
assert.deepEqual(getCustomAliases(), { "team-default": "openai/gpt-4o-mini" });
assert.equal(getBackgroundDegradationConfig().enabled, true);
assert.equal(getBackgroundDegradationConfig().degradationMap["gpt-4o"], "gpt-4o-mini");
assert.deepEqual(getBackgroundDegradationConfig().detectionPatterns, ["summarize this"]);
assert.equal((await getPayloadRulesConfig()).override[0].params.temperature, 0.1);
assert.equal(await getCacheControlSettings(), "always");
assert.equal(getGeminiThoughtSignatureMode(), "bypass");
await settingsDb.updateSettings({
cliCompatProviders: [],
modelAliases: {},
backgroundDegradation: null,
payloadRules: null,
alwaysPreserveClientCache: "auto",
antigravitySignatureCacheMode: "enabled",
});
assert.deepEqual(getCliCompatProviders(), []);
assert.deepEqual(getCustomAliases(), {});
assert.equal(getBackgroundDegradationConfig().enabled, false);
assert.equal((await getPayloadRulesConfig()).override.length, 0);
assert.equal(await getCacheControlSettings(), "auto");
assert.equal(getGeminiThoughtSignatureMode(), "enabled");
});
test("MODELS_DEV_SYNC_ENABLED=0 blocks a live settings update from starting the sync timer", async () => {
const previousEnvFlag = process.env.MODELS_DEV_SYNC_ENABLED;
const previousBackgroundTasks = process.env.OMNIROUTE_ENABLE_RUNTIME_BACKGROUND_TASKS;
process.env.MODELS_DEV_SYNC_ENABLED = "0";
process.env.OMNIROUTE_ENABLE_RUNTIME_BACKGROUND_TASKS = "1";
stopPeriodicSync();
try {
await applyRuntimeSettings(
{
...(await settingsDb.getSettings()),
modelsDevSyncEnabled: false,
modelsDevSyncInterval: 3_600_000,
},
{ force: true, source: "test:startup" }
);
const persistedSettings = await settingsDb.updateSettings({
modelsDevSyncEnabled: true,
modelsDevSyncInterval: 3_600_000,
});
assert.equal(
persistedSettings.modelsDevSyncEnabled,
true,
"the live settings update must persist the dashboard toggle"
);
assert.equal(
getSyncStatus().enabled,
false,
"MODELS_DEV_SYNC_ENABLED=0 must prevent a live settings update from starting the timer"
);
} finally {
stopPeriodicSync();
if (previousEnvFlag === undefined) delete process.env.MODELS_DEV_SYNC_ENABLED;
else process.env.MODELS_DEV_SYNC_ENABLED = previousEnvFlag;
if (previousBackgroundTasks === undefined) {
delete process.env.OMNIROUTE_ENABLE_RUNTIME_BACKGROUND_TASKS;
} else {
process.env.OMNIROUTE_ENABLE_RUNTIME_BACKGROUND_TASKS = previousBackgroundTasks;
}
}
});
test("hot-reload watcher picks up external sqlite changes via polling fallback", async () => {
await applyRuntimeSettings(await settingsDb.getSettings(), {
force: true,
source: "test:startup",
});
startRuntimeConfigHotReload({ pollIntervalMs: 100 });
const db = getDbInstance();
db.prepare(
"INSERT OR REPLACE INTO key_value (namespace, key, value) VALUES ('settings', 'cliCompatProviders', ?)"
).run(JSON.stringify(["github", "openai"]));
db.prepare(
"INSERT OR REPLACE INTO key_value (namespace, key, value) VALUES ('settings', 'antigravitySignatureCacheMode', ?)"
).run(JSON.stringify("bypass-strict"));
await waitFor(
() =>
getCliCompatProviders().includes("github") &&
!getCliCompatProviders().includes("openai") &&
getGeminiThoughtSignatureMode() === "bypass-strict"
);
});