mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
82 lines
3.4 KiB
TypeScript
82 lines
3.4 KiB
TypeScript
/**
|
|
* Regression test for /api/conversations's `activeCallLogId` field.
|
|
*
|
|
* `call_logs` only gets its row on completion (src/lib/usage/callLogs.ts's
|
|
* INSERT needs duration/status/tokens, none of which exist yet while a reply
|
|
* is still streaming) — so `lastCallLogId` (joined from `call_logs`) always
|
|
* lags one request behind for a conversation with an in-flight reply. The
|
|
* conversation panel needs the CURRENT pending request's own id (tracked
|
|
* separately, in-memory, via usageHistory's pendingById) to poll its live
|
|
* partial text. This test proves the route surfaces that id, keyed off the
|
|
* pending request's `sessionTag` (== the conversation's own id).
|
|
*/
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-conv-active-call-log-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const agenticConversations = await import("../../src/lib/db/agenticConversations.ts");
|
|
const usageHistory = await import("../../src/lib/usage/usageHistory.ts");
|
|
const route = await import("../../src/app/api/conversations/route.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
usageHistory.clearPendingRequests();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test.beforeEach(() => {
|
|
usageHistory.clearPendingRequests();
|
|
});
|
|
|
|
function seedTwoTurnConversation(id: string) {
|
|
agenticConversations.createAgenticConversation({ id, apiKeyId: null, fingerprintHash: "fp" });
|
|
agenticConversations.insertConversationTurnNodes(id, null, [
|
|
{ id: `${id}-n1`, parentId: null, role: "user", contentHash: "h1" },
|
|
{ id: `${id}-n2`, parentId: `${id}-n1`, role: "assistant", contentHash: "h2" },
|
|
]);
|
|
}
|
|
|
|
test("GET /api/conversations: surfaces the in-flight pending request's own id as activeCallLogId", async () => {
|
|
const conversationId = "conv_active_test_1";
|
|
seedTwoTurnConversation(conversationId);
|
|
|
|
const pendingId = usageHistory.trackPendingRequest("gpt-4", "openai", "conn-1", true, {
|
|
sessionTag: conversationId,
|
|
});
|
|
assert.ok(pendingId, "trackPendingRequest should return the generated pending id");
|
|
|
|
const res = await route.GET(new Request("http://localhost/api/conversations?limit=50"));
|
|
assert.equal(res.status, 200);
|
|
const body = (await res.json()) as {
|
|
conversations: Array<{ id: string; isActive: boolean; activeCallLogId: string | null }>;
|
|
};
|
|
|
|
const row = body.conversations.find((c) => c.id === conversationId);
|
|
assert.ok(row, "seeded conversation should be present in the response");
|
|
assert.equal(row!.isActive, true);
|
|
assert.equal(row!.activeCallLogId, pendingId);
|
|
});
|
|
|
|
test("GET /api/conversations: activeCallLogId is null for a conversation with no in-flight request", async () => {
|
|
const conversationId = "conv_active_test_2";
|
|
seedTwoTurnConversation(conversationId);
|
|
|
|
const res = await route.GET(new Request("http://localhost/api/conversations?limit=50"));
|
|
assert.equal(res.status, 200);
|
|
const body = (await res.json()) as {
|
|
conversations: Array<{ id: string; isActive: boolean; activeCallLogId: string | null }>;
|
|
};
|
|
|
|
const row = body.conversations.find((c) => c.id === conversationId);
|
|
assert.ok(row, "seeded conversation should be present in the response");
|
|
assert.equal(row!.isActive, false);
|
|
assert.equal(row!.activeCallLogId, null);
|
|
});
|