mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-16 11:52:26 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
42 lines
1.6 KiB
TypeScript
42 lines
1.6 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { goldenSnapshot } from "../../helpers/goldenSnapshot.ts";
|
|
|
|
// Use an isolated tmpdir so the selftest does not pollute tests/snapshots/
|
|
let tmpDir: string;
|
|
|
|
test("goldenSnapshot writes on first run then matches", (t) => {
|
|
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "golden-selftest-"));
|
|
|
|
// First run: UPDATE_GOLDEN=1 → writes
|
|
process.env.UPDATE_GOLDEN = "1";
|
|
goldenSnapshot("selftest/sample", { b: 2, a: 1 }, tmpDir);
|
|
delete process.env.UPDATE_GOLDEN;
|
|
|
|
// Re-run without flag: same value (keys re-ordered) → should pass
|
|
assert.doesNotThrow(() => goldenSnapshot("selftest/sample", { a: 1, b: 2 }, tmpDir));
|
|
|
|
// Mismatch: different value → should throw
|
|
assert.throws(() => goldenSnapshot("selftest/sample", { a: 1, b: 3 }, tmpDir));
|
|
|
|
// Cleanup
|
|
fs.rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("goldenSnapshot first-run (no UPDATE_GOLDEN) writes and passes", () => {
|
|
const td = fs.mkdtempSync(path.join(os.tmpdir(), "golden-first-run-"));
|
|
try {
|
|
// File does not exist yet: should write and not throw
|
|
assert.doesNotThrow(() => goldenSnapshot("test/value", { x: 42 }, td));
|
|
// File now exists: same value should pass
|
|
assert.doesNotThrow(() => goldenSnapshot("test/value", { x: 42 }, td));
|
|
// File exists: different value should throw
|
|
assert.throws(() => goldenSnapshot("test/value", { x: 99 }, td));
|
|
} finally {
|
|
fs.rmSync(td, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|