mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-10 17:02:22 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
132 lines
5.0 KiB
JavaScript
132 lines
5.0 KiB
JavaScript
// ENVIRONMENT NOTE (sandbox better-sqlite3 / glibc limitation, not a code defect):
|
|
// This test constructs or exercises a real better-sqlite3-backed SQLite database.
|
|
// better-sqlite3 is a native addon; production and CI load it normally, but some
|
|
// sandboxes/dev boxes ship a system glibc older than the prebuilt binary requires
|
|
// ("GLIBC_2.29 not found"), so the native module fails to dlopen and any test that
|
|
// reaches better-sqlite3 directly (or asserts stdout that the load-failure warning
|
|
// would pollute) fails HERE while passing in CI. This is a known environment
|
|
// limitation, not a defect in the code under test: the OmniRoute runtime itself
|
|
// cascades to node:sqlite/sql.js when better-sqlite3 is unavailable. See
|
|
// tests/unit/_helpers/betterSqlite3Availability.ts for a guard helper.
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const Database = (await import("better-sqlite3")).default;
|
|
|
|
const { getCursorVersion, resetCursorVersionCache, FALLBACK_VERSION } =
|
|
await import("../../open-sse/utils/cursorVersionDetector.ts");
|
|
|
|
function createStateDb(dir, version) {
|
|
const dbPath = path.join(dir, "state.vscdb");
|
|
const db = new Database(dbPath);
|
|
db.exec("CREATE TABLE itemTable (key TEXT PRIMARY KEY, value TEXT)");
|
|
if (version) {
|
|
db.prepare("INSERT INTO itemTable (key, value) VALUES (?, ?)").run(
|
|
"cursorupdate.lastUpdatedAndShown.version",
|
|
version
|
|
);
|
|
}
|
|
db.close();
|
|
return dbPath;
|
|
}
|
|
|
|
test("getCursorVersion reads version from state.vscdb", () => {
|
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-ver-"));
|
|
const dbPath = createStateDb(tmpDir, "99.0.1");
|
|
const origEnv = process.env.CURSOR_STATE_DB_PATH;
|
|
process.env.CURSOR_STATE_DB_PATH = dbPath;
|
|
|
|
try {
|
|
resetCursorVersionCache();
|
|
assert.equal(getCursorVersion(), "99.0.1");
|
|
} finally {
|
|
if (origEnv === undefined) delete process.env.CURSOR_STATE_DB_PATH;
|
|
else process.env.CURSOR_STATE_DB_PATH = origEnv;
|
|
fs.rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("getCursorVersion returns fallback when DB does not exist", () => {
|
|
const origEnv = process.env.CURSOR_STATE_DB_PATH;
|
|
process.env.CURSOR_STATE_DB_PATH = "/nonexistent/path/state.vscdb";
|
|
|
|
try {
|
|
resetCursorVersionCache();
|
|
assert.equal(getCursorVersion(), FALLBACK_VERSION);
|
|
} finally {
|
|
if (origEnv === undefined) delete process.env.CURSOR_STATE_DB_PATH;
|
|
else process.env.CURSOR_STATE_DB_PATH = origEnv;
|
|
}
|
|
});
|
|
|
|
test("getCursorVersion returns fallback when DB has no version key", () => {
|
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-ver-nokey-"));
|
|
const dbPath = createStateDb(tmpDir, null);
|
|
const origEnv = process.env.CURSOR_STATE_DB_PATH;
|
|
process.env.CURSOR_STATE_DB_PATH = dbPath;
|
|
|
|
try {
|
|
resetCursorVersionCache();
|
|
assert.equal(getCursorVersion(), FALLBACK_VERSION);
|
|
} finally {
|
|
if (origEnv === undefined) delete process.env.CURSOR_STATE_DB_PATH;
|
|
else process.env.CURSOR_STATE_DB_PATH = origEnv;
|
|
fs.rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("getCursorVersion caches the result across calls", () => {
|
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-ver-cache-"));
|
|
const dbPath = createStateDb(tmpDir, "10.0.0");
|
|
const origEnv = process.env.CURSOR_STATE_DB_PATH;
|
|
process.env.CURSOR_STATE_DB_PATH = dbPath;
|
|
|
|
try {
|
|
resetCursorVersionCache();
|
|
assert.equal(getCursorVersion(), "10.0.0");
|
|
|
|
// Update the DB — cache should still return old value
|
|
const db = new Database(dbPath);
|
|
db.prepare("UPDATE itemTable SET value = ? WHERE key = ?").run(
|
|
"20.0.0",
|
|
"cursorupdate.lastUpdatedAndShown.version"
|
|
);
|
|
db.close();
|
|
|
|
assert.equal(getCursorVersion(), "10.0.0", "cached value should be returned");
|
|
} finally {
|
|
if (origEnv === undefined) delete process.env.CURSOR_STATE_DB_PATH;
|
|
else process.env.CURSOR_STATE_DB_PATH = origEnv;
|
|
fs.rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("resetCursorVersionCache forces re-read from DB", () => {
|
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-ver-reset-"));
|
|
const dbPath = createStateDb(tmpDir, "5.0.0");
|
|
const origEnv = process.env.CURSOR_STATE_DB_PATH;
|
|
process.env.CURSOR_STATE_DB_PATH = dbPath;
|
|
|
|
try {
|
|
resetCursorVersionCache();
|
|
assert.equal(getCursorVersion(), "5.0.0");
|
|
|
|
const db = new Database(dbPath);
|
|
db.prepare("UPDATE itemTable SET value = ? WHERE key = ?").run(
|
|
"6.0.0",
|
|
"cursorupdate.lastUpdatedAndShown.version"
|
|
);
|
|
db.close();
|
|
|
|
resetCursorVersionCache();
|
|
assert.equal(getCursorVersion(), "6.0.0", "should re-read after cache reset");
|
|
} finally {
|
|
if (origEnv === undefined) delete process.env.CURSOR_STATE_DB_PATH;
|
|
else process.env.CURSOR_STATE_DB_PATH = origEnv;
|
|
fs.rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|