mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-10 08:52:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
84 lines
3.0 KiB
TypeScript
84 lines
3.0 KiB
TypeScript
/**
|
|
* Issue #2905 — custom models (added via the UI) on opencode-go / openai-compatible
|
|
* nodes always routed as OpenAI-compatible because there was no way to set a
|
|
* per-model `targetFormat`. `addCustomModel` didn't accept it, the API schema
|
|
* stripped it, and routing (`getModelTargetFormat`, static-registry-only) never
|
|
* saw it — so a custom model that needs the Anthropic Messages shape fell back
|
|
* to the provider default ("openai").
|
|
*
|
|
* This test verifies the persistence + getModelInfo-injection chain: a custom
|
|
* model saved with targetFormat: "claude" is surfaced on the resolved modelInfo
|
|
* (which chatCore then uses before the provider default).
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-custom-target-format-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const modelsDb = await import("../../src/lib/db/models.ts");
|
|
const { getModelInfo } = await import("../../src/sse/services/model.ts");
|
|
|
|
test.before(async () => {
|
|
await providersDb.createProviderNode({
|
|
id: "openai-compatible-2905",
|
|
type: "openai-compatible",
|
|
name: "Gateway 2905",
|
|
prefix: "g29",
|
|
baseUrl: "https://proxy.example.com",
|
|
chatPath: "/v1/chat/completions",
|
|
modelsPath: "/v1/models",
|
|
});
|
|
});
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("#2905 addCustomModel persists targetFormat", async () => {
|
|
await modelsDb.addCustomModel(
|
|
"openai-compatible-2905",
|
|
"my-claude-model",
|
|
"My Claude Model",
|
|
"manual",
|
|
"chat-completions",
|
|
["chat"],
|
|
"claude"
|
|
);
|
|
const models = (await modelsDb.getCustomModels("openai-compatible-2905")) as Array<{
|
|
id: string;
|
|
targetFormat?: string;
|
|
}>;
|
|
const saved = models.find((m) => m.id === "my-claude-model");
|
|
assert.ok(saved, "custom model must be saved");
|
|
assert.equal(saved.targetFormat, "claude", "targetFormat must be persisted");
|
|
});
|
|
|
|
test("#2905 getModelInfo surfaces the custom model targetFormat", async () => {
|
|
const info = (await getModelInfo("g29/my-claude-model")) as {
|
|
provider?: string;
|
|
targetFormat?: string;
|
|
};
|
|
assert.equal(info.provider, "openai-compatible-2905", "must resolve to the custom node");
|
|
assert.equal(info.targetFormat, "claude", "getModelInfo must inject the custom targetFormat");
|
|
});
|
|
|
|
test("#2905 a custom model without targetFormat surfaces none (provider default applies)", async () => {
|
|
await modelsDb.addCustomModel(
|
|
"openai-compatible-2905",
|
|
"plain-model",
|
|
"Plain Model",
|
|
"manual",
|
|
"chat-completions",
|
|
["chat"]
|
|
);
|
|
const info = (await getModelInfo("g29/plain-model")) as { targetFormat?: string };
|
|
assert.equal(info.targetFormat, undefined, "no targetFormat → falls back to provider default");
|
|
});
|