Files
OmniRoute/tests/unit/db-agent-bridge-bypass.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

132 lines
4.2 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-db-agent-bridge-bypass-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const mod = await import("../../src/lib/db/agentBridgeBypass.ts");
async function resetStorage() {
core.resetDbInstance();
for (let attempt = 0; attempt < 10; attempt++) {
try {
if (fs.existsSync(TEST_DATA_DIR)) {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
break;
} catch (error: any) {
if ((error?.code === "EBUSY" || error?.code === "EPERM") && attempt < 9) {
await new Promise((resolve) => setTimeout(resolve, 50 * (attempt + 1)));
} else {
throw error;
}
}
}
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(async () => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
const DEFAULT_PATTERNS = [
"*.googleapis.com",
"*.gstatic.com",
"accounts.google.com",
"login.microsoftonline.com",
];
test("getAllBypassPatterns returns empty array when table is empty", () => {
const rows = mod.getAllBypassPatterns();
assert.deepEqual(rows, []);
});
test("seedDefaultBypassPatterns inserts default patterns with source=default", () => {
mod.seedDefaultBypassPatterns(DEFAULT_PATTERNS);
const rows = mod.getAllBypassPatterns();
assert.equal(rows.length, DEFAULT_PATTERNS.length);
for (const row of rows) {
assert.equal(row.source, "default");
assert.ok(DEFAULT_PATTERNS.includes(row.pattern));
}
});
test("seedDefaultBypassPatterns is idempotent — calling twice does not duplicate", () => {
mod.seedDefaultBypassPatterns(DEFAULT_PATTERNS);
mod.seedDefaultBypassPatterns(DEFAULT_PATTERNS);
const rows = mod.getAllBypassPatterns();
assert.equal(rows.length, DEFAULT_PATTERNS.length);
});
test("getUserBypassPatterns returns only user patterns", () => {
mod.seedDefaultBypassPatterns(DEFAULT_PATTERNS);
mod.replaceUserBypassPatterns(["*.internal.example.com", "localhost"]);
const userPatterns = mod.getUserBypassPatterns();
assert.equal(userPatterns.length, 2);
assert.ok(userPatterns.includes("*.internal.example.com"));
assert.ok(userPatterns.includes("localhost"));
// Defaults should not appear in user patterns
for (const p of DEFAULT_PATTERNS) {
assert.ok(!userPatterns.includes(p));
}
});
test("replaceUserBypassPatterns replaces only user entries — defaults untouched", () => {
mod.seedDefaultBypassPatterns(DEFAULT_PATTERNS);
mod.replaceUserBypassPatterns(["custom.host.1"]);
mod.replaceUserBypassPatterns(["custom.host.2", "custom.host.3"]);
const allRows = mod.getAllBypassPatterns();
const defaultRows = allRows.filter((r) => r.source === "default");
const userRows = allRows.filter((r) => r.source === "user");
assert.equal(defaultRows.length, DEFAULT_PATTERNS.length);
assert.equal(userRows.length, 2);
const userPatterns = userRows.map((r) => r.pattern);
assert.ok(!userPatterns.includes("custom.host.1"), "old user pattern must be replaced");
assert.ok(userPatterns.includes("custom.host.2"));
assert.ok(userPatterns.includes("custom.host.3"));
});
test("replaceUserBypassPatterns with empty array clears all user patterns", () => {
mod.seedDefaultBypassPatterns(DEFAULT_PATTERNS);
mod.replaceUserBypassPatterns(["temp.host"]);
mod.replaceUserBypassPatterns([]);
const userPatterns = mod.getUserBypassPatterns();
assert.equal(userPatterns.length, 0);
// Defaults remain
const allRows = mod.getAllBypassPatterns();
assert.equal(allRows.length, DEFAULT_PATTERNS.length);
});
test("getAllBypassPatterns returns both default and user patterns", () => {
mod.seedDefaultBypassPatterns(["*.example.com"]);
mod.replaceUserBypassPatterns(["custom.host"]);
const allRows = mod.getAllBypassPatterns();
assert.equal(allRows.length, 2);
const sources = new Set(allRows.map((r) => r.source));
assert.ok(sources.has("default"));
assert.ok(sources.has("user"));
});