Files
OmniRoute/tests/unit/db-agent-bridge-mappings.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

125 lines
4.1 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-db-agent-bridge-mappings-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const mod = await import("../../src/lib/db/agentBridgeMappings.ts");
async function resetStorage() {
core.resetDbInstance();
for (let attempt = 0; attempt < 10; attempt++) {
try {
if (fs.existsSync(TEST_DATA_DIR)) {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
break;
} catch (error: any) {
if ((error?.code === "EBUSY" || error?.code === "EPERM") && attempt < 9) {
await new Promise((resolve) => setTimeout(resolve, 50 * (attempt + 1)));
} else {
throw error;
}
}
}
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(async () => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("getMappingsForAgent returns empty array when no mappings exist", () => {
const rows = mod.getMappingsForAgent("antigravity");
assert.deepEqual(rows, []);
});
test("setMappings inserts and retrieves mappings for an agent", () => {
mod.setMappings("copilot", [
{ source: "gpt-4", target: "openai/gpt-4.1" },
{ source: "gpt-3.5-turbo", target: "openai/gpt-4o-mini" },
]);
const rows = mod.getMappingsForAgent("copilot");
assert.equal(rows.length, 2);
const sources = rows.map((r) => r.source_model);
assert.ok(sources.includes("gpt-4"));
assert.ok(sources.includes("gpt-3.5-turbo"));
const gpt4Row = rows.find((r) => r.source_model === "gpt-4");
assert.equal(gpt4Row?.target_model, "openai/gpt-4.1");
assert.equal(gpt4Row?.agent_id, "copilot");
});
test("setMappings is transactional — replaces all mappings idempotently", () => {
// First set
mod.setMappings("cursor", [
{ source: "claude-3-5-sonnet", target: "anthropic/claude-sonnet-4-5" },
]);
// Second set — should replace (not accumulate)
mod.setMappings("cursor", [
{ source: "claude-3-opus", target: "anthropic/claude-opus-4" },
{ source: "gpt-4o", target: "openai/gpt-4.1" },
]);
const rows = mod.getMappingsForAgent("cursor");
assert.equal(rows.length, 2);
const sources = rows.map((r) => r.source_model);
assert.ok(!sources.includes("claude-3-5-sonnet"), "old mapping should be replaced");
assert.ok(sources.includes("claude-3-opus"));
assert.ok(sources.includes("gpt-4o"));
});
test("setMappings with empty array clears all mappings for agent", () => {
mod.setMappings("zed", [{ source: "gpt-4", target: "openai/gpt-4.1" }]);
mod.setMappings("zed", []);
const rows = mod.getMappingsForAgent("zed");
assert.equal(rows.length, 0);
});
test("setMappings does not affect mappings for other agents", () => {
mod.setMappings("kiro", [{ source: "gpt-4", target: "openai/gpt-4.1" }]);
mod.setMappings("codex", [{ source: "o3", target: "openai/o3" }]);
mod.setMappings("kiro", [{ source: "gpt-4o", target: "openai/gpt-4o" }]);
const codexRows = mod.getMappingsForAgent("codex");
assert.equal(codexRows.length, 1);
assert.equal(codexRows[0].source_model, "o3");
});
test("deleteMapping removes a specific source mapping", () => {
mod.setMappings("antigravity", [
{ source: "gpt-4", target: "openai/gpt-4.1" },
{ source: "gpt-3.5-turbo", target: "openai/gpt-4o-mini" },
]);
mod.deleteMapping("antigravity", "gpt-4");
const rows = mod.getMappingsForAgent("antigravity");
assert.equal(rows.length, 1);
assert.equal(rows[0].source_model, "gpt-3.5-turbo");
});
test("deleteMapping is a no-op when mapping does not exist", () => {
mod.setMappings("claude-code", [{ source: "claude-3", target: "anthropic/claude-opus-4" }]);
mod.deleteMapping("claude-code", "nonexistent-model");
const rows = mod.getMappingsForAgent("claude-code");
assert.equal(rows.length, 1);
});