mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-17 20:32:25 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
76 lines
2.8 KiB
TypeScript
76 lines
2.8 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-db-health-driver-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "db-health-driver-secret";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const healthCheckDb = await import("../../src/lib/db/healthCheck.ts");
|
|
const driverFactory = await import("../../src/lib/db/adapters/driverFactory.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
// ─── describeDbDriver: pure decision ───────────────────
|
|
|
|
test("the sql.js WASM fallback is reported degraded", () => {
|
|
assert.deepEqual(
|
|
healthCheckDb.describeDbDriver({ driver: "sql.js", name: "/data/storage.sqlite" }),
|
|
{
|
|
name: "sql.js",
|
|
degraded: true,
|
|
}
|
|
);
|
|
});
|
|
|
|
test("a native driver backed by a real file is not degraded", () => {
|
|
for (const driver of ["better-sqlite3", "node:sqlite", "bun:sqlite"] as const) {
|
|
assert.deepEqual(healthCheckDb.describeDbDriver({ driver, name: "/data/storage.sqlite" }), {
|
|
name: driver,
|
|
degraded: false,
|
|
});
|
|
}
|
|
});
|
|
|
|
test("an in-memory database is degraded even on a native driver", () => {
|
|
for (const driver of ["better-sqlite3", "node:sqlite", "bun:sqlite", "sql.js"] as const) {
|
|
assert.deepEqual(healthCheckDb.describeDbDriver({ driver, name: ":memory:" }), {
|
|
name: driver,
|
|
degraded: true,
|
|
});
|
|
}
|
|
});
|
|
|
|
// ─── runDbHealthCheck: wiring against ground truth ─────
|
|
|
|
test("the health check reports the driver of the database it actually ran against", () => {
|
|
const db = core.getDbInstance();
|
|
const result = healthCheckDb.runDbHealthCheck(db, { autoRepair: false });
|
|
|
|
assert.equal(result.driver.name, db.driver);
|
|
|
|
// Precondition: the fixture is file-backed, so `degraded` is asserted as a literal
|
|
// rather than re-derived from the implementation's own condition.
|
|
assert.ok(db.name.endsWith(".sqlite"), `expected a file-backed fixture, got ${db.name}`);
|
|
assert.equal(result.driver.degraded, false);
|
|
});
|
|
|
|
test("an in-memory database opened through the real cascade is reported degraded", () => {
|
|
// Same tryOpenSync() the cloud/build path reaches through openSqliteDatabase(), so the
|
|
// `:memory:` name is observed from the adapter rather than assumed.
|
|
const memoryAdapter = driverFactory.tryOpenSync(":memory:");
|
|
assert.ok(memoryAdapter, "expected the native cascade to open an in-memory database");
|
|
try {
|
|
assert.equal(memoryAdapter.name, ":memory:");
|
|
assert.equal(healthCheckDb.describeDbDriver(memoryAdapter).degraded, true);
|
|
} finally {
|
|
memoryAdapter.close();
|
|
}
|
|
});
|