mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 10:52:17 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
96 lines
3.4 KiB
TypeScript
96 lines
3.4 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-db-aliases-cascade-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const models = await import("../../src/lib/db/models.ts");
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
|
|
for (let attempt = 0; attempt < 10; attempt++) {
|
|
try {
|
|
if (fs.existsSync(TEST_DATA_DIR)) {
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
break;
|
|
} catch (error: any) {
|
|
if ((error?.code === "EBUSY" || error?.code === "EPERM") && attempt < 9) {
|
|
await new Promise((resolve) => setTimeout(resolve, 50 * (attempt + 1)));
|
|
} else {
|
|
throw error;
|
|
}
|
|
}
|
|
}
|
|
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(async () => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("deleteModelAliasesForProvider removes only the target provider's aliases", async () => {
|
|
// Managed/imported aliases are stored as key=<alias>, value="<providerId>/<model>".
|
|
await models.setModelAlias("x-fast", "providerX/fast-model");
|
|
await models.setModelAlias("x-smart", "providerX/smart-model");
|
|
await models.setModelAlias("y-mini", "providerY/mini-model");
|
|
|
|
const removed = await models.deleteModelAliasesForProvider("providerX");
|
|
|
|
assert.deepEqual(removed.sort(), ["x-fast", "x-smart"]);
|
|
|
|
const after = await models.getModelAliases();
|
|
// providerX aliases are gone…
|
|
assert.equal(after["x-fast"], undefined);
|
|
assert.equal(after["x-smart"], undefined);
|
|
// …and providerY's alias remains untouched.
|
|
assert.equal(after["y-mini"], "providerY/mini-model");
|
|
});
|
|
|
|
test("deleteModelAliasesForProvider does not match providers sharing a name prefix", async () => {
|
|
// "providerX" must not cascade-delete "providerXL"'s aliases (no partial-prefix match).
|
|
await models.setModelAlias("x-fast", "providerX/fast-model");
|
|
await models.setModelAlias("xl-fast", "providerXL/fast-model");
|
|
|
|
const removed = await models.deleteModelAliasesForProvider("providerX");
|
|
|
|
assert.deepEqual(removed, ["x-fast"]);
|
|
|
|
const after = await models.getModelAliases();
|
|
assert.equal(after["x-fast"], undefined);
|
|
assert.equal(after["xl-fast"], "providerXL/fast-model");
|
|
});
|
|
|
|
test("after cascade delete, re-adding the same provider alias succeeds (re-import unblocked)", async () => {
|
|
await models.setModelAlias("x-fast", "providerX/fast-model");
|
|
|
|
await models.deleteModelAliasesForProvider("providerX");
|
|
|
|
// Re-import: the alias key/value can be set again with no stale row blocking it.
|
|
await models.setModelAlias("x-fast", "providerX/fast-model");
|
|
|
|
const after = await models.getModelAliases();
|
|
assert.equal(after["x-fast"], "providerX/fast-model");
|
|
});
|
|
|
|
test("deleteModelAliasesForProvider returns an empty list when there is nothing to remove", async () => {
|
|
await models.setModelAlias("y-mini", "providerY/mini-model");
|
|
|
|
const removed = await models.deleteModelAliasesForProvider("providerX");
|
|
|
|
assert.deepEqual(removed, []);
|
|
const after = await models.getModelAliases();
|
|
assert.equal(after["y-mini"], "providerY/mini-model");
|
|
});
|