Files
OmniRoute/tests/unit/db-model-context-overrides.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

94 lines
3.8 KiB
TypeScript

import { describe, it, beforeEach, after } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// Feature 5004 — model_context_overrides DB module round-trip.
const moduleDataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omni-mco-module-"));
process.env.DATA_DIR = moduleDataDir;
const coreDb = await import("../../src/lib/db/core.ts");
const mco = await import("../../src/lib/db/modelContextOverrides.ts");
function resetStorage() {
coreDb.resetDbInstance();
fs.rmSync(moduleDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(moduleDataDir, { recursive: true });
}
beforeEach(() => {
resetStorage();
// Touch the DB so migration 110 creates the table.
coreDb.getDbInstance();
});
after(() => {
coreDb.resetDbInstance();
fs.rmSync(moduleDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
describe("modelContextOverrides", () => {
it("returns null when there is no override", () => {
assert.equal(mco.getModelContextOverride("openai", "gpt-5"), null);
assert.equal(mco.getModelContextOverrideRecord("openai", "gpt-5"), null);
});
it("round-trips a manual override (set -> get -> record)", () => {
assert.equal(mco.setModelContextOverride("openai", "gpt-5", 400000), true);
assert.equal(mco.getModelContextOverride("openai", "gpt-5"), 400000);
const rec = mco.getModelContextOverrideRecord("openai", "gpt-5");
assert.equal(rec?.realContext, 400000);
assert.equal(rec?.source, "manual");
assert.equal(rec?.provider, "openai");
assert.equal(rec?.modelId, "gpt-5");
});
it("upserts on the same (provider, model) key and records the source", () => {
mco.setModelContextOverride("anthropic", "claude-sonnet-4-5", 200000, "auto:discovery");
assert.equal(
mco.getModelContextOverrideRecord("anthropic", "claude-sonnet-4-5")?.source,
"auto:discovery"
);
// Re-set as manual overwrites the same row.
mco.setModelContextOverride("anthropic", "claude-sonnet-4-5", 1000000, "manual");
const rec = mco.getModelContextOverrideRecord("anthropic", "claude-sonnet-4-5");
assert.equal(rec?.realContext, 1000000);
assert.equal(rec?.source, "manual");
assert.equal(mco.listModelContextOverrides().length, 1);
});
it("rejects non-positive / non-integer windows and empty keys (no write)", () => {
assert.equal(mco.setModelContextOverride("openai", "gpt-5", 0), false);
assert.equal(mco.setModelContextOverride("openai", "gpt-5", -1), false);
assert.equal(mco.setModelContextOverride("openai", "gpt-5", 1.5), false);
assert.equal(mco.setModelContextOverride("", "gpt-5", 1000), false);
assert.equal(mco.setModelContextOverride("openai", " ", 1000), false);
assert.equal(mco.getModelContextOverride("openai", "gpt-5"), null);
});
it("trims keys so lookups match writes", () => {
mco.setModelContextOverride(" openai ", " gpt-5 ", 333000);
assert.equal(mco.getModelContextOverride("openai", "gpt-5"), 333000);
});
it("removes an override", () => {
mco.setModelContextOverride("groq", "llama-3.3-70b", 128000);
assert.equal(mco.removeModelContextOverride("groq", "llama-3.3-70b"), true);
assert.equal(mco.getModelContextOverride("groq", "llama-3.3-70b"), null);
assert.equal(mco.removeModelContextOverride("groq", "llama-3.3-70b"), false);
});
it("lists all overrides", () => {
mco.setModelContextOverride("openai", "gpt-5", 400000);
mco.setModelContextOverride("anthropic", "claude-sonnet-4-5", 200000, "auto:discovery");
const all = mco.listModelContextOverrides();
assert.equal(all.length, 2);
assert.deepEqual(all.map((o) => `${o.provider}/${o.modelId}`).sort(), [
"anthropic/claude-sonnet-4-5",
"openai/gpt-5",
]);
});
});