Files
OmniRoute/tests/unit/db-provider-plans.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

213 lines
6.7 KiB
TypeScript

/**
* tests/unit/db-provider-plans.test.ts
*
* Coverage for src/lib/db/providerPlans.ts:
* - upsertPlan idempotence (same key twice → 1 row)
* - deletePlan removes the row
* - listPlans returns all stored plans
* - getPlan parses dimensions_json correctly
* - Malformed dimensions_json handled gracefully
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-provider-plans-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const plansDb = await import("../../src/lib/db/providerPlans.ts");
async function resetStorage() {
core.resetDbInstance();
for (let attempt = 0; attempt < 10; attempt++) {
try {
if (fs.existsSync(TEST_DATA_DIR)) {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
break;
} catch (err: any) {
if ((err?.code === "EBUSY" || err?.code === "EPERM") && attempt < 9) {
await new Promise((resolve) => setTimeout(resolve, 50 * (attempt + 1)));
} else {
throw err;
}
}
}
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(async () => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
// ---------------------------------------------------------------------------
// upsertPlan — idempotence
// ---------------------------------------------------------------------------
test("upsertPlan creates a plan row", () => {
plansDb.upsertPlan("conn-1", "codex", [{ unit: "percent", window: "5h", limit: 100 }], "auto");
const all = plansDb.listPlans();
assert.equal(all.length, 1);
assert.equal(all[0].connectionId, "conn-1");
assert.equal(all[0].provider, "codex");
});
test("upsertPlan with same connectionId twice yields exactly 1 row", () => {
plansDb.upsertPlan(
"conn-idempotent",
"kimi",
[{ unit: "requests", window: "hourly", limit: 1500 }],
"auto"
);
plansDb.upsertPlan(
"conn-idempotent",
"kimi",
[{ unit: "requests", window: "hourly", limit: 2000 }], // updated limit
"manual"
);
const all = plansDb.listPlans();
assert.equal(all.length, 1, "should have exactly 1 row after 2 upserts");
assert.equal(all[0].dimensions[0].limit, 2000, "should have the latest limit");
assert.equal(all[0].source, "manual", "should have the latest source");
});
// ---------------------------------------------------------------------------
// getPlan — parse dimensions_json
// ---------------------------------------------------------------------------
test("getPlan returns null for unknown connectionId", () => {
const plan = plansDb.getPlan("no-such-conn");
assert.equal(plan, null);
});
test("getPlan returns a plan with correctly parsed dimensions", () => {
plansDb.upsertPlan(
"conn-parse",
"bailian",
[
{ unit: "percent", window: "5h", limit: 100 },
{ unit: "percent", window: "weekly", limit: 100 },
],
"auto"
);
const plan = plansDb.getPlan("conn-parse");
assert.ok(plan, "should return a plan");
assert.equal(plan!.provider, "bailian");
assert.equal(plan!.dimensions.length, 2);
assert.equal(plan!.dimensions[0].unit, "percent");
assert.equal(plan!.dimensions[0].window, "5h");
assert.equal(plan!.dimensions[0].limit, 100);
assert.equal(plan!.dimensions[1].window, "weekly");
assert.equal(plan!.source, "auto");
});
test("getPlan parses all QuotaUnit and QuotaWindow variants correctly", () => {
const dims = [
{ unit: "percent" as const, window: "5h" as const, limit: 100 },
{ unit: "requests" as const, window: "hourly" as const, limit: 1500 },
{ unit: "tokens" as const, window: "daily" as const, limit: 50_000 },
{ unit: "usd" as const, window: "monthly" as const, limit: 10 },
];
plansDb.upsertPlan("conn-variants", "multi", dims, "manual");
const plan = plansDb.getPlan("conn-variants");
assert.ok(plan);
assert.equal(plan!.dimensions.length, 4);
for (let i = 0; i < dims.length; i++) {
assert.equal(plan!.dimensions[i].unit, dims[i].unit);
assert.equal(plan!.dimensions[i].window, dims[i].window);
assert.equal(plan!.dimensions[i].limit, dims[i].limit);
}
});
// ---------------------------------------------------------------------------
// listPlans
// ---------------------------------------------------------------------------
test("listPlans returns all stored plans", () => {
plansDb.upsertPlan("conn-a", "codex", [{ unit: "percent", window: "5h", limit: 100 }], "auto");
plansDb.upsertPlan(
"conn-b",
"kimi",
[{ unit: "requests", window: "hourly", limit: 1500 }],
"manual"
);
plansDb.upsertPlan(
"conn-c",
"bailian",
[{ unit: "percent", window: "monthly", limit: 100 }],
"auto"
);
const plans = plansDb.listPlans();
assert.equal(plans.length, 3);
const providers = plans.map((p) => p.provider).sort();
assert.deepEqual(providers, ["bailian", "codex", "kimi"]);
});
test("listPlans returns empty array when no plans exist", () => {
const plans = plansDb.listPlans();
assert.deepEqual(plans, []);
});
// ---------------------------------------------------------------------------
// deletePlan
// ---------------------------------------------------------------------------
test("deletePlan removes the plan and returns true", () => {
plansDb.upsertPlan(
"conn-delete-me",
"codex",
[{ unit: "percent", window: "5h", limit: 100 }],
"auto"
);
const deleted = plansDb.deletePlan("conn-delete-me");
assert.equal(deleted, true);
assert.equal(plansDb.getPlan("conn-delete-me"), null);
assert.equal(plansDb.listPlans().length, 0);
});
test("deletePlan returns false for unknown connectionId", () => {
const deleted = plansDb.deletePlan("ghost-connection");
assert.equal(deleted, false);
});
// ---------------------------------------------------------------------------
// upsertPlan + upsert doesn't destroy other rows
// ---------------------------------------------------------------------------
test("upserting one plan does not affect other connection plans", () => {
plansDb.upsertPlan("conn-x", "openai", [{ unit: "usd", window: "monthly", limit: 50 }], "manual");
plansDb.upsertPlan(
"conn-y",
"anthropic",
[{ unit: "tokens", window: "daily", limit: 100_000 }],
"auto"
);
// Update conn-x
plansDb.upsertPlan(
"conn-x",
"openai",
[{ unit: "usd", window: "monthly", limit: 100 }],
"manual"
);
const planY = plansDb.getPlan("conn-y");
assert.ok(planY, "conn-y should still exist");
assert.equal(planY!.dimensions[0].limit, 100_000);
});