mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
76 lines
2.8 KiB
TypeScript
76 lines
2.8 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
|
|
|
|
async function withRecoveryEnv(fn: (dataDir: string) => Promise<void>) {
|
|
const dataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-db-recovery-"));
|
|
process.env.DATA_DIR = dataDir;
|
|
try {
|
|
await fn(dataDir);
|
|
} finally {
|
|
fs.rmSync(dataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
if (ORIGINAL_DATA_DIR === undefined) delete process.env.DATA_DIR;
|
|
else process.env.DATA_DIR = ORIGINAL_DATA_DIR;
|
|
}
|
|
}
|
|
|
|
test("countEncryptedCredentials returns 0 on fresh db", async () => {
|
|
await withRecoveryEnv(async () => {
|
|
const { countEncryptedCredentials } = await import("../../src/lib/db/recovery.ts");
|
|
const count = countEncryptedCredentials();
|
|
assert.equal(count, 0);
|
|
});
|
|
});
|
|
|
|
test("resetEncryptedColumns dry-run returns affected count without mutating", async () => {
|
|
await withRecoveryEnv(async () => {
|
|
const { resetEncryptedColumns, countEncryptedCredentials } =
|
|
await import("../../src/lib/db/recovery.ts");
|
|
|
|
// Insert a fake encrypted row directly using the DB instance
|
|
const { getDbInstance } = await import("../../src/lib/db/core.ts");
|
|
const db = getDbInstance();
|
|
const now = new Date().toISOString();
|
|
db.prepare(
|
|
"INSERT INTO provider_connections (id, provider, name, api_key, created_at, updated_at) VALUES (?,?,?,?,?,?)"
|
|
).run("test-id", "openai", "test-conn", "enc:v1:fake-encrypted-value", now, now);
|
|
|
|
const countBefore = countEncryptedCredentials();
|
|
assert.equal(countBefore, 1);
|
|
|
|
const { affected } = resetEncryptedColumns({ dryRun: true });
|
|
assert.equal(affected, 1);
|
|
|
|
// Dry run should NOT have mutated
|
|
const countAfter = countEncryptedCredentials();
|
|
assert.equal(countAfter, 1);
|
|
});
|
|
});
|
|
|
|
test("resetEncryptedColumns force mode nulls encrypted columns", async () => {
|
|
await withRecoveryEnv(async () => {
|
|
const { resetEncryptedColumns } = await import("../../src/lib/db/recovery.ts");
|
|
const { getDbInstance } = await import("../../src/lib/db/core.ts");
|
|
|
|
const db = getDbInstance();
|
|
const now = new Date().toISOString();
|
|
db.prepare(
|
|
"INSERT INTO provider_connections (id, provider, name, api_key, access_token, created_at, updated_at) VALUES (?,?,?,?,?,?,?)"
|
|
).run("rec-id", "anthropic", "rec-conn", "enc:v1:key123", "enc:v1:tok456", now, now);
|
|
|
|
const { affected } = resetEncryptedColumns({ dryRun: false });
|
|
assert.ok(affected >= 1);
|
|
|
|
const row = db
|
|
.prepare("SELECT api_key, access_token FROM provider_connections WHERE id = ?")
|
|
.get("rec-id") as { api_key: null; access_token: null } | undefined;
|
|
assert.ok(row);
|
|
assert.equal(row.api_key, null);
|
|
assert.equal(row.access_token, null);
|
|
});
|
|
});
|