Files
OmniRoute/tests/unit/db-webhooks.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

91 lines
3.0 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omni-db-webhooks-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const coreDb = await import("../../src/lib/db/core.ts");
const webhooksDb = await import("../../src/lib/db/webhooks.ts");
async function resetStorage() {
coreDb.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(() => {
coreDb.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("webhooks create, update, query enabled hooks and delete records", () => {
const created = webhooksDb.createWebhook({
url: "https://example.com/hook",
events: ["request.completed"],
description: "Primary webhook",
});
assert.match(created.secret, /^whsec_/);
assert.equal(webhooksDb.getWebhooks().webhooks.length, 1);
assert.equal(webhooksDb.getEnabledWebhooks().length, 1);
const updated = webhooksDb.updateWebhook(created.id, {
enabled: false,
events: ["request.failed"],
secret: "custom-secret",
description: "Updated webhook",
});
assert.equal(updated.enabled, false);
assert.deepEqual(updated.events, ["request.failed"]);
assert.equal(updated.secret, "custom-secret");
assert.equal(webhooksDb.getEnabledWebhooks().length, 0);
assert.equal(webhooksDb.deleteWebhook(created.id), true);
assert.equal(webhooksDb.deleteWebhook(created.id), false);
});
test("webhooks record delivery success and failures", () => {
const created = webhooksDb.createWebhook({
url: "https://example.com/hook",
});
webhooksDb.recordWebhookDelivery(created.id, 500, false);
webhooksDb.recordWebhookDelivery(created.id, 502, false);
let stored = webhooksDb.getWebhook(created.id);
assert.equal(stored.failure_count, 2);
assert.equal(stored.last_status, 502);
webhooksDb.recordWebhookDelivery(created.id, 200, true);
stored = webhooksDb.getWebhook(created.id);
assert.equal(stored.failure_count, 0);
assert.equal(stored.last_status, 200);
assert.ok(stored.last_triggered_at);
});
test("webhooks disable only hooks above the failure threshold", () => {
const a = webhooksDb.createWebhook({ url: "https://example.com/a" });
const b = webhooksDb.createWebhook({ url: "https://example.com/b" });
for (let i = 0; i < 3; i++) {
webhooksDb.recordWebhookDelivery(a.id, 500, false);
}
webhooksDb.recordWebhookDelivery(b.id, 500, false);
const disabled = webhooksDb.disableWebhooksWithHighFailures(2);
assert.equal(disabled, 1);
assert.equal(webhooksDb.getWebhook(a.id).enabled, false);
assert.equal(webhooksDb.getWebhook(b.id).enabled, true);
assert.equal(webhooksDb.updateWebhook("ghost", { enabled: false }), null);
});