mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
109 lines
3.7 KiB
TypeScript
109 lines
3.7 KiB
TypeScript
/**
|
|
* TDD for F4.1 — recordContextEditingTelemetry: writes a compression_analytics
|
|
* row under engine "context-editing" for the tokens the provider cleared via
|
|
* server-side context editing.
|
|
*
|
|
* DB isolation pattern mirrors tests/unit/db/per-engine-analytics.test.ts:
|
|
* - Temp DATA_DIR, resetDbInstance() before/after, restore in test.after().
|
|
*
|
|
* Run: node --import tsx/esm --test tests/unit/db/context-editing-telemetry-record.test.ts
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-ctx-edit-telemetry-"));
|
|
const originalDataDir = process.env.DATA_DIR;
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../../src/lib/db/core.ts");
|
|
core.resetDbInstance();
|
|
|
|
const {
|
|
recordContextEditingTelemetry,
|
|
getCompressionAnalyticsSummary,
|
|
getLatestCompressionAnalyticsRun,
|
|
} = await import("../../../src/lib/db/compressionAnalytics.ts");
|
|
|
|
function resetDb(): void {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(() => {
|
|
resetDb();
|
|
});
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
if (originalDataDir === undefined) delete process.env.DATA_DIR;
|
|
else process.env.DATA_DIR = originalDataDir;
|
|
});
|
|
|
|
test("records a context-editing row reflected in byEngine analytics", () => {
|
|
recordContextEditingTelemetry(
|
|
"req-1",
|
|
{ editCount: 1, clearedInputTokens: 50000, clearedToolUses: 8 },
|
|
"claude"
|
|
);
|
|
const summary = getCompressionAnalyticsSummary();
|
|
assert.ok(summary.byEngine["context-editing"], "byEngine has a context-editing bucket");
|
|
assert.equal(summary.byEngine["context-editing"].count, 1);
|
|
assert.equal(summary.byEngine["context-editing"].tokensSaved, 50000);
|
|
assert.equal(summary.totalTokensSaved, 50000);
|
|
});
|
|
|
|
test("is a no-op when nothing was cleared (clearedInputTokens <= 0)", () => {
|
|
recordContextEditingTelemetry("req-2", {
|
|
editCount: 1,
|
|
clearedInputTokens: 0,
|
|
clearedToolUses: 0,
|
|
});
|
|
const summary = getCompressionAnalyticsSummary();
|
|
assert.equal(summary.totalRequests, 0, "no row written");
|
|
assert.equal(summary.byEngine["context-editing"], undefined);
|
|
});
|
|
|
|
test("is a no-op for null/undefined telemetry", () => {
|
|
recordContextEditingTelemetry("req-3", null as never);
|
|
recordContextEditingTelemetry("req-4", undefined as never);
|
|
assert.equal(getCompressionAnalyticsSummary().totalRequests, 0);
|
|
});
|
|
|
|
test("uses a suffixed request_id so it never collides with the usage-receipt UPDATE", () => {
|
|
recordContextEditingTelemetry(
|
|
"abc123",
|
|
{ editCount: 1, clearedInputTokens: 1000, clearedToolUses: 1 },
|
|
"claude"
|
|
);
|
|
const latest = getLatestCompressionAnalyticsRun();
|
|
assert.ok(latest);
|
|
assert.equal(latest.engine, "context-editing");
|
|
assert.equal(latest.mode, "context-editing");
|
|
assert.notEqual(latest.request_id, "abc123", "must not reuse the raw request id");
|
|
assert.ok(
|
|
typeof latest.request_id === "string" && latest.request_id.startsWith("abc123"),
|
|
"stays traceable to the originating request"
|
|
);
|
|
});
|
|
|
|
test("aggregates multiple context-editing rows", () => {
|
|
recordContextEditingTelemetry("r1", {
|
|
editCount: 1,
|
|
clearedInputTokens: 1000,
|
|
clearedToolUses: 1,
|
|
});
|
|
recordContextEditingTelemetry("r2", {
|
|
editCount: 2,
|
|
clearedInputTokens: 2500,
|
|
clearedToolUses: 3,
|
|
});
|
|
const summary = getCompressionAnalyticsSummary();
|
|
assert.equal(summary.byEngine["context-editing"].count, 2);
|
|
assert.equal(summary.byEngine["context-editing"].tokensSaved, 3500);
|
|
});
|