mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
145 lines
4.7 KiB
TypeScript
145 lines
4.7 KiB
TypeScript
import { describe, test, before, after } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { mkdtempSync, rmSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
|
|
// Isolate the DB into a throwaway DATA_DIR so migrations run against a fresh file.
|
|
let tmpDataDir: string;
|
|
let mod: typeof import("@/lib/db/discoveryResults");
|
|
let core: typeof import("@/lib/db/core");
|
|
|
|
before(async () => {
|
|
tmpDataDir = mkdtempSync(join(tmpdir(), "omniroute-discovery-"));
|
|
process.env.DATA_DIR = tmpDataDir;
|
|
core = await import("@/lib/db/core");
|
|
core.resetDbInstance();
|
|
// Touch the instance so migrations (incl. 074_discovery_results) apply.
|
|
core.getDbInstance();
|
|
mod = await import("@/lib/db/discoveryResults");
|
|
});
|
|
|
|
after(() => {
|
|
core.resetDbInstance();
|
|
if (tmpDataDir)
|
|
rmSync(tmpDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
describe("discoveryResults DB module", () => {
|
|
test("upsert inserts a new row and returns it with an id", () => {
|
|
const row = mod.upsertDiscoveryResult({
|
|
providerId: "acme",
|
|
method: "free_tier",
|
|
authType: "none",
|
|
feasibility: 4,
|
|
riskLevel: "low",
|
|
status: "pending",
|
|
models: ["acme-large", "acme-small"],
|
|
endpoint: "https://acme.example/api",
|
|
});
|
|
assert.ok(typeof row.id === "number" && row.id > 0);
|
|
assert.equal(row.providerId, "acme");
|
|
assert.deepEqual(row.models, ["acme-large", "acme-small"]);
|
|
assert.equal(row.status, "pending");
|
|
});
|
|
|
|
test("upsert on the same (provider, method, endpoint) updates instead of duplicating", () => {
|
|
const first = mod.upsertDiscoveryResult({
|
|
providerId: "beta",
|
|
method: "web_cookie",
|
|
authType: "cookie",
|
|
feasibility: 3,
|
|
riskLevel: "medium",
|
|
status: "pending",
|
|
endpoint: "https://beta.example/chat",
|
|
});
|
|
const second = mod.upsertDiscoveryResult({
|
|
providerId: "beta",
|
|
method: "web_cookie",
|
|
authType: "cookie",
|
|
feasibility: 5,
|
|
riskLevel: "medium",
|
|
status: "testing",
|
|
endpoint: "https://beta.example/chat",
|
|
});
|
|
assert.equal(second.id, first.id);
|
|
assert.equal(second.feasibility, 5);
|
|
assert.equal(second.status, "testing");
|
|
const all = mod.getDiscoveryResults("beta");
|
|
assert.equal(all.length, 1);
|
|
});
|
|
|
|
test("getDiscoveryResults filters by providerId and returns all when omitted", () => {
|
|
const beta = mod.getDiscoveryResults("beta");
|
|
assert.ok(beta.every((r) => r.providerId === "beta"));
|
|
const all = mod.getDiscoveryResults();
|
|
assert.ok(all.length >= 2);
|
|
});
|
|
|
|
test("getDiscoveryResultById returns the row or null", () => {
|
|
const created = mod.upsertDiscoveryResult({
|
|
providerId: "gamma",
|
|
method: "trial",
|
|
authType: "api_key",
|
|
feasibility: 2,
|
|
riskLevel: "low",
|
|
status: "pending",
|
|
});
|
|
const found = mod.getDiscoveryResultById(created.id!);
|
|
assert.equal(found?.providerId, "gamma");
|
|
assert.equal(mod.getDiscoveryResultById(999999), null);
|
|
});
|
|
|
|
test("markVerified sets status=verified and stamps verified_at", () => {
|
|
const created = mod.upsertDiscoveryResult({
|
|
providerId: "delta",
|
|
method: "public_api",
|
|
authType: "api_key",
|
|
feasibility: 5,
|
|
riskLevel: "none",
|
|
status: "pending",
|
|
});
|
|
const updated = mod.markVerified(created.id!);
|
|
assert.equal(updated?.status, "verified");
|
|
assert.ok(updated?.verifiedAt);
|
|
});
|
|
|
|
test("markVerified on a missing id returns null", () => {
|
|
assert.equal(mod.markVerified(999999), null);
|
|
});
|
|
|
|
test("deleteDiscoveryResult removes the row and returns true, false if absent", () => {
|
|
const created = mod.upsertDiscoveryResult({
|
|
providerId: "epsilon",
|
|
method: "free_tier",
|
|
authType: "none",
|
|
feasibility: 1,
|
|
riskLevel: "none",
|
|
status: "pending",
|
|
});
|
|
assert.equal(mod.deleteDiscoveryResult(created.id!), true);
|
|
assert.equal(mod.getDiscoveryResultById(created.id!), null);
|
|
assert.equal(mod.deleteDiscoveryResult(created.id!), false);
|
|
});
|
|
});
|
|
|
|
describe("discovery service reporter delegation", () => {
|
|
test("persistDiscoveryResult writes through and getDiscoveryResults reads it back", async () => {
|
|
const svc = await import("@/lib/discovery/index");
|
|
const saved = svc.persistDiscoveryResult({
|
|
providerId: "zeta",
|
|
method: "public_api",
|
|
authType: "api_key",
|
|
feasibility: 5,
|
|
riskLevel: "none",
|
|
status: "verified",
|
|
models: ["zeta-1"],
|
|
});
|
|
assert.ok(saved.id! > 0);
|
|
const read = svc.getDiscoveryResults("zeta");
|
|
assert.equal(read.length, 1);
|
|
assert.equal(read[0].providerId, "zeta");
|
|
assert.deepEqual(read[0].models, ["zeta-1"]);
|
|
});
|
|
});
|