Files
OmniRoute/tests/unit/db/weak-rng-fixes.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

56 lines
2.1 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-weak-rng-"));
process.env.DATA_DIR = TEST_DATA_DIR;
test.after(() => {
try {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
} catch {}
});
test("quotaPools.makeId returns UUID without Math.random fallback", async () => {
const { createPool } = await import("../../../src/lib/db/quotaPools.ts");
const core = await import("../../../src/lib/db/core.ts");
core.resetDbInstance();
const pool = createPool({ connectionId: "test-conn", name: "test-pool" });
const uuidRegex = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i;
assert.match(pool.id, uuidRegex, `ID should be UUID format, got: ${pool.id}`);
});
test("quotaGroups.makeId returns UUID without Math.random fallback", async () => {
const { createGroup } = await import("../../../src/lib/db/quotaGroups.ts");
const core = await import("../../../src/lib/db/core.ts");
core.resetDbInstance();
const group = createGroup("test-group");
const uuidRegex = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i;
assert.match(group.id, uuidRegex, `ID should be UUID format, got: ${group.id}`);
});
test("quotaPools.makeId produces unique IDs across calls", async () => {
const { createPool } = await import("../../../src/lib/db/quotaPools.ts");
const core = await import("../../../src/lib/db/core.ts");
const ids = new Set<string>();
for (let i = 0; i < 10; i++) {
core.resetDbInstance();
const pool = createPool({ connectionId: "test-conn", name: `pool-${i}` });
ids.add(pool.id);
}
assert.equal(ids.size, 10, "All 10 IDs should be unique");
});
test("migrationRunner probe table format uses crypto.randomUUID", async () => {
const probeName = `__omniroute_fts5_probe_${crypto.randomUUID().replace(/-/g, "_")}`;
assert.match(
probeName,
/^__omniroute_fts5_probe_[0-9a-f]{8}_[0-9a-f]{4}_[0-9a-f]{4}_[0-9a-f]{4}_[0-9a-f]{12}$/i
);
});