mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-16 11:52:26 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
155 lines
4.3 KiB
TypeScript
155 lines
4.3 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-domain-lockout-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const lockoutPolicy = await import("../../src/domain/lockoutPolicy.ts");
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
|
|
for (let attempt = 0; attempt < 10; attempt++) {
|
|
try {
|
|
if (fs.existsSync(TEST_DATA_DIR)) {
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
break;
|
|
} catch (error: any) {
|
|
if ((error?.code === "EBUSY" || error?.code === "EPERM") && attempt < 9) {
|
|
await new Promise((resolve) => setTimeout(resolve, 50 * (attempt + 1)));
|
|
} else {
|
|
throw error;
|
|
}
|
|
}
|
|
}
|
|
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
const originalDateNow = Date.now;
|
|
|
|
test.beforeEach(async () => {
|
|
Date.now = originalDateNow;
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(async () => {
|
|
Date.now = originalDateNow;
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("checkLockout starts unlocked and locks after reaching the configured threshold", () => {
|
|
let now = 1_000;
|
|
Date.now = () => now;
|
|
|
|
const id = "lockout-threshold";
|
|
const config = {
|
|
maxAttempts: 3,
|
|
lockoutDurationMs: 500,
|
|
attemptWindowMs: 200,
|
|
};
|
|
|
|
assert.deepEqual(lockoutPolicy.checkLockout(id, config), {
|
|
locked: false,
|
|
attempts: 0,
|
|
});
|
|
|
|
assert.deepEqual(lockoutPolicy.recordFailedAttempt(id, config), { locked: false });
|
|
now += 50;
|
|
assert.deepEqual(lockoutPolicy.recordFailedAttempt(id, config), { locked: false });
|
|
now += 50;
|
|
assert.deepEqual(lockoutPolicy.recordFailedAttempt(id, config), {
|
|
locked: true,
|
|
remainingMs: 500,
|
|
});
|
|
|
|
const locked = lockoutPolicy.checkLockout(id, config);
|
|
assert.equal(locked.locked, true);
|
|
assert.equal(locked.attempts, 3);
|
|
assert.equal(locked.remainingMs, 500);
|
|
});
|
|
|
|
test("expired lockouts are cleared and stale attempts outside the window are pruned", () => {
|
|
let now = 10_000;
|
|
Date.now = () => now;
|
|
|
|
const id = "lockout-expiry";
|
|
const config = {
|
|
maxAttempts: 2,
|
|
lockoutDurationMs: 100,
|
|
attemptWindowMs: 50,
|
|
};
|
|
|
|
lockoutPolicy.recordFailedAttempt(id, config);
|
|
now += 60;
|
|
assert.deepEqual(lockoutPolicy.recordFailedAttempt(id, config), { locked: false });
|
|
|
|
now += 10;
|
|
assert.deepEqual(lockoutPolicy.recordFailedAttempt(id, config), {
|
|
locked: true,
|
|
remainingMs: 100,
|
|
});
|
|
|
|
now += 120;
|
|
assert.deepEqual(lockoutPolicy.checkLockout(id, config), {
|
|
locked: false,
|
|
attempts: 0,
|
|
});
|
|
});
|
|
|
|
test("recordSuccess and forceUnlock remove tracked identifiers", () => {
|
|
const config = {
|
|
maxAttempts: 1,
|
|
lockoutDurationMs: 1_000,
|
|
attemptWindowMs: 1_000,
|
|
};
|
|
|
|
lockoutPolicy.recordFailedAttempt("unlock-success", config);
|
|
assert.equal(lockoutPolicy.checkLockout("unlock-success", config).locked, true);
|
|
lockoutPolicy.recordSuccess("unlock-success");
|
|
assert.deepEqual(lockoutPolicy.checkLockout("unlock-success", config), {
|
|
locked: false,
|
|
attempts: 0,
|
|
});
|
|
|
|
lockoutPolicy.recordFailedAttempt("unlock-force", config);
|
|
assert.equal(lockoutPolicy.checkLockout("unlock-force", config).locked, true);
|
|
lockoutPolicy.forceUnlock("unlock-force");
|
|
assert.deepEqual(lockoutPolicy.checkLockout("unlock-force", config), {
|
|
locked: false,
|
|
attempts: 0,
|
|
});
|
|
});
|
|
|
|
test("getLockedIdentifiers returns active lockouts and filters expired ones", () => {
|
|
let now = 20_000;
|
|
Date.now = () => now;
|
|
|
|
const shortConfig = {
|
|
maxAttempts: 1,
|
|
lockoutDurationMs: 50,
|
|
attemptWindowMs: 500,
|
|
};
|
|
const longConfig = {
|
|
maxAttempts: 1,
|
|
lockoutDurationMs: 500,
|
|
attemptWindowMs: 500,
|
|
};
|
|
|
|
lockoutPolicy.recordFailedAttempt("expired-id", shortConfig);
|
|
lockoutPolicy.recordFailedAttempt("active-id", longConfig);
|
|
now += 100;
|
|
|
|
const locked = lockoutPolicy.getLockedIdentifiers();
|
|
|
|
assert.ok(locked.some((entry) => entry.identifier === "active-id"));
|
|
assert.ok(!locked.some((entry) => entry.identifier === "expired-id"));
|
|
assert.ok(locked.find((entry) => entry.identifier === "active-id").remainingMs > 0);
|
|
});
|