mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-21 06:12:17 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
96 lines
3.2 KiB
TypeScript
96 lines
3.2 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-embed-cooldown-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "embed-cooldown-test-secret";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const auth = await import("../../src/sse/services/auth.ts");
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
async function seedConnection(provider: string): Promise<string> {
|
|
const conn = await providersDb.createProviderConnection({
|
|
provider,
|
|
authType: "apikey",
|
|
apiKey: `${provider}-key`,
|
|
isActive: true,
|
|
testStatus: "active",
|
|
});
|
|
return (conn as Record<string, unknown>).id as string;
|
|
}
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("#10347: markAccountUnavailable triggers cooldown on embedding 402", async () => {
|
|
await resetStorage();
|
|
const connId = await seedConnection("mistral");
|
|
|
|
const result = await auth.markAccountUnavailable(
|
|
connId,
|
|
402,
|
|
"Check your subscription on https://admin.mistral.ai/subscription",
|
|
"mistral",
|
|
"mistral-embed"
|
|
);
|
|
|
|
assert.strictEqual(result.shouldFallback, true, "402 must trigger account cooldown");
|
|
|
|
// Verify the connection was marked — 402 is terminal (credits_exhausted),
|
|
// which sets testStatus but not rateLimitedUntil
|
|
const conn = await providersDb.getProviderConnectionById(connId);
|
|
assert.strictEqual(
|
|
conn.testStatus,
|
|
"credits_exhausted",
|
|
"402 must mark connection credits_exhausted"
|
|
);
|
|
});
|
|
|
|
test("#10347: markAccountUnavailable triggers cooldown on embedding 500", async () => {
|
|
await resetStorage();
|
|
const connId = await seedConnection("mistral");
|
|
|
|
const result = await auth.markAccountUnavailable(
|
|
connId,
|
|
500,
|
|
"Internal server error",
|
|
"mistral",
|
|
"mistral-embed"
|
|
);
|
|
|
|
assert.strictEqual(result.shouldFallback, true, "500 must trigger account cooldown");
|
|
const conn = await providersDb.getProviderConnectionById(connId);
|
|
assert.strictEqual(conn.testStatus, "unavailable", "500 must mark connection unavailable");
|
|
});
|
|
|
|
test("#10347: embedding 400 (bad request) does NOT trigger account cooldown", async () => {
|
|
await resetStorage();
|
|
const connId = await seedConnection("mistral");
|
|
|
|
// 400 bad request is a client error, not an account issue — should not cool down
|
|
const result = await auth.markAccountUnavailable(
|
|
connId,
|
|
400,
|
|
"Invalid embedding input format",
|
|
"mistral",
|
|
"mistral-embed"
|
|
);
|
|
|
|
// Generic 400 returns shouldFallback:false (not account-fallback-worthy)
|
|
assert.strictEqual(result.shouldFallback, false, "400 bad request must not trigger cooldown");
|
|
const conn = await providersDb.getProviderConnectionById(connId);
|
|
assert.strictEqual(conn.testStatus, "active", "400 must keep connection active");
|
|
});
|