Files
OmniRoute/tests/unit/embedding-cooldown-integration-10347.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

185 lines
6.5 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// #10347 integration: exercise createEmbeddingResponse end-to-end with a
// mocked upstream that returns 402, then verify the connection gets cooled
// down. This proves the production code path actually calls
// markAccountUnavailable — the direct-call tests in
// embedding-account-cooldown-10347.test.ts would pass even if the
// production block were removed.
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-embed-int-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "embed-int-test-secret";
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const auth = await import("../../src/sse/services/auth.ts");
function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
async function seedConnection(
provider: string,
overrides: Record<string, unknown> = {}
): Promise<string> {
const conn = await providersDb.createProviderConnection({
provider,
authType: "apikey",
apiKey: `${provider}-key`,
isActive: true,
testStatus: "active",
...overrides,
});
return (conn as Record<string, unknown>).id as string;
}
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("createEmbeddingResponse marks connection on upstream 402", async () => {
resetStorage();
const connId = await seedConnection("mistral");
// Mock upstream to return 402 (subscription expired).
const originalFetch = globalThis.fetch;
globalThis.fetch = (async () =>
new Response(
JSON.stringify({ error: "Check your subscription on https://admin.mistral.ai/subscription" }),
{ status: 402, headers: { "Content-Type": "application/json" } }
)) as typeof globalThis.fetch;
try {
// Import the service AFTER seeding the DB so its module-level caches
// see the seeded connection.
const { createEmbeddingResponse } = await import("../../src/lib/embeddings/service.ts");
// Call the production path — this must exercise the markAccountUnavailable
// block we added in #10347.
const res = await createEmbeddingResponse(
{ model: "mistral-embed", input: "hello" },
{ connectionId: connId }
);
assert.equal(res.status, 402, "must return upstream status");
// Give the fire-and-forget markAccountUnavailable call time to settle.
await new Promise((r) => setImmediate(r));
await new Promise((r) => setImmediate(r));
// Verify the connection was actually marked — this is the assertion
// that would FAIL if the production block were removed.
const conn = await providersDb.getProviderConnectionById(connId);
assert.equal(
conn.testStatus,
"credits_exhausted",
"402 must mark connection credits_exhausted via production code path"
);
} finally {
globalThis.fetch = originalFetch;
}
});
test("cooled account is skipped on next request — second connection selected", async () => {
resetStorage();
const conn1 = await seedConnection("mistral", { apiKey: "mistral-key-1" });
const conn2 = await seedConnection("mistral", { apiKey: "mistral-key-2" });
const originalFetch = globalThis.fetch;
let fetchCallCount = 0;
try {
const { createEmbeddingResponse } = await import("../../src/lib/embeddings/service.ts");
// First request: upstream returns 402 → conn1 gets cooled.
globalThis.fetch = (async () => {
fetchCallCount++;
return new Response(JSON.stringify({ error: "subscription expired" }), {
status: 402,
headers: { "Content-Type": "application/json" },
});
}) as typeof globalThis.fetch;
const res1 = await createEmbeddingResponse(
{ model: "mistral-embed", input: "hello" },
{ connectionId: conn1 }
);
assert.equal(res1.status, 402);
// Wait for fire-and-forget cooldown write.
await new Promise((r) => setImmediate(r));
await new Promise((r) => setImmediate(r));
// Verify conn1 is cooled.
const conn1After = await providersDb.getProviderConnectionById(conn1);
assert.equal(conn1After.testStatus, "credits_exhausted", "conn1 must be cooled");
// Second request: upstream returns 200.
globalThis.fetch = (async () => {
fetchCallCount++;
return new Response(
JSON.stringify({
data: [{ embedding: [0.1, 0.2], index: 0 }],
model: "mistral-embed",
usage: { prompt_tokens: 1, total_tokens: 1 },
}),
{ status: 200, headers: { "Content-Type": "application/json" } }
);
}) as typeof globalThis.fetch;
// Call without specifying connectionId — credential selection should
// skip conn1 (credits_exhausted) and pick conn2.
const res2 = await createEmbeddingResponse({ model: "mistral-embed", input: "world" }, {});
assert.equal(res2.status, 200, "second request must succeed via conn2");
// Verify conn2 is still healthy.
const conn2After = await providersDb.getProviderConnectionById(conn2);
assert.equal(conn2After.testStatus, "active", "conn2 must remain active");
} finally {
globalThis.fetch = originalFetch;
}
});
test("createEmbeddingResponse skips 400 (bad request) — no cooldown", async () => {
resetStorage();
const connId = await seedConnection("mistral");
const originalFetch = globalThis.fetch;
globalThis.fetch = (async () =>
new Response(JSON.stringify({ error: "Invalid embedding input format" }), {
status: 400,
headers: { "Content-Type": "application/json" },
})) as typeof globalThis.fetch;
try {
const { createEmbeddingResponse } = await import("../../src/lib/embeddings/service.ts");
const res = await createEmbeddingResponse(
{ model: "mistral-embed", input: "hello" },
{ connectionId: connId }
);
assert.equal(res.status, 400, "must return upstream status");
await new Promise((r) => setImmediate(r));
await new Promise((r) => setImmediate(r));
const conn = await providersDb.getProviderConnectionById(connId);
assert.equal(
conn.testStatus,
"active",
"400 must NOT mark connection — account is fine, request was wrong"
);
} finally {
globalThis.fetch = originalFetch;
}
});