Files
OmniRoute/tests/unit/embedding-family-guard.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

107 lines
4.1 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import { mkdtempSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
// familyGuard imports combo.ts which transitively touches DB modules at load;
// give it a throwaway DATA_DIR so it uses defaults instead of the real store.
process.env.DATA_DIR = mkdtempSync(join(tmpdir(), "omniroute-embed-family-"));
const { getEmbeddingDimension, detectEmbeddingDimensionConflict } = await import(
"../../open-sse/config/embeddingRegistry.ts"
);
const { findEmbeddingComboDimensionConflict } = await import(
"../../src/lib/embeddings/familyGuard.ts"
);
test("getEmbeddingDimension resolves known dimensions from the registry", () => {
assert.equal(getEmbeddingDimension("openai/text-embedding-3-small"), 1536);
assert.equal(getEmbeddingDimension("openai/text-embedding-3-large"), 3072);
assert.equal(getEmbeddingDimension("nebius/Qwen/Qwen3-Embedding-8B"), 4096);
assert.equal(getEmbeddingDimension("gemini/gemini-embedding-001"), 768);
assert.equal(getEmbeddingDimension("gemini/gemini-embedding-2"), 3072);
assert.equal(getEmbeddingDimension("google/gemini-embedding-2"), 3072);
// OpenRouter re-exports OpenAI ids under its own prefix at the same dimension.
assert.equal(getEmbeddingDimension("openrouter/openai/text-embedding-3-small"), 1536);
});
test("getEmbeddingDimension returns undefined for unknown/local models", () => {
assert.equal(getEmbeddingDimension("localembed/my-model"), undefined);
assert.equal(getEmbeddingDimension("mystery/whatever"), undefined);
});
test("detectEmbeddingDimensionConflict flags mixed vector spaces", () => {
const res = detectEmbeddingDimensionConflict([
"openai/text-embedding-3-small", // 1536
"nebius/Qwen/Qwen3-Embedding-8B", // 4096
]);
assert.equal(res.conflict, true);
assert.deepEqual(res.distinct, [1536, 4096]);
});
test("detectEmbeddingDimensionConflict accepts a uniform dimension", () => {
const res = detectEmbeddingDimensionConflict([
"openai/text-embedding-3-small", // 1536
"openrouter/openai/text-embedding-3-small", // 1536
]);
assert.equal(res.conflict, false);
assert.deepEqual(res.distinct, [1536]);
});
test("detectEmbeddingDimensionConflict ignores unknown dimensions (no false positive)", () => {
const res = detectEmbeddingDimensionConflict([
"openai/text-embedding-3-small", // 1536 (known)
"localembed/unknown", // undefined (ignored)
]);
assert.equal(res.conflict, false);
assert.deepEqual(res.distinct, [1536]);
});
test("detectEmbeddingDimensionConflict is a no-op for empty / all-unknown lists", () => {
assert.equal(detectEmbeddingDimensionConflict([]).conflict, false);
assert.equal(
detectEmbeddingDimensionConflict(["localembed/a", "localembed/b"]).conflict,
false
);
});
test("findEmbeddingComboDimensionConflict flags a mixed-dimension embedding combo", () => {
const combo = {
name: "mixed-embeds",
models: [
{ model: "openai/text-embedding-3-small" }, // 1536
{ model: "nebius/Qwen/Qwen3-Embedding-8B" }, // 4096
],
};
const res = findEmbeddingComboDimensionConflict(combo, [combo]);
assert.equal(res.conflict, true);
assert.deepEqual(res.distinct, [1536, 4096]);
});
test("findEmbeddingComboDimensionConflict passes a uniform embedding combo", () => {
const combo = {
name: "uniform-embeds",
models: [
{ model: "openai/text-embedding-3-small" }, // 1536
{ model: "openrouter/openai/text-embedding-3-small" }, // 1536
],
};
const res = findEmbeddingComboDimensionConflict(combo, [combo]);
assert.equal(res.conflict, false);
});
test("findEmbeddingComboDimensionConflict expands nested combos before checking", () => {
const child = {
name: "child-embeds",
models: [
{ model: "openai/text-embedding-3-small" }, // 1536
{ model: "nebius/Qwen/Qwen3-Embedding-8B" }, // 4096
],
};
const parent = { name: "parent-embeds", models: [{ model: "child-embeds" }] };
const res = findEmbeddingComboDimensionConflict(parent, [parent, child]);
assert.equal(res.conflict, true);
assert.deepEqual(res.distinct, [1536, 4096]);
});