mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-17 04:12:17 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
78 lines
2.5 KiB
TypeScript
78 lines
2.5 KiB
TypeScript
import assert from "node:assert/strict";
|
|
import test from "node:test";
|
|
|
|
import { ESLint } from "eslint";
|
|
|
|
const eslint = new ESLint({ cwd: process.cwd() });
|
|
|
|
async function restrictedImportMessages(code: string, filePath: string): Promise<string[]> {
|
|
const [result] = await eslint.lintText(code, { filePath });
|
|
|
|
return result.messages
|
|
.filter(({ ruleId }) => ruleId === "no-restricted-imports")
|
|
.map(({ message }) => message);
|
|
}
|
|
|
|
test("G14 rejects localDb barrel imports outside src/lib/db", async () => {
|
|
const cases = [
|
|
{
|
|
code: 'import { getSettings } from "@/lib/localDb";\nvoid getSettings;',
|
|
filePath: "src/lib/example.ts",
|
|
},
|
|
{
|
|
code: 'import { getSettings } from "@/lib/localDb.ts";\nvoid getSettings;',
|
|
filePath: "src/shared/example.ts",
|
|
},
|
|
{
|
|
code: 'import { getSettings } from "../localDb";\nvoid getSettings;',
|
|
filePath: "src/lib/feature/example.ts",
|
|
},
|
|
{
|
|
code: 'import { getSettings } from "../../lib/localDb.ts";\nvoid getSettings;',
|
|
filePath: "src/app/example.ts",
|
|
},
|
|
];
|
|
|
|
for (const fixture of cases) {
|
|
const messages = await restrictedImportMessages(fixture.code, fixture.filePath);
|
|
assert.equal(messages.length, 1, `expected ${fixture.code} to be rejected`);
|
|
assert.match(messages[0], /domain module from `@\/lib\/db\//);
|
|
}
|
|
});
|
|
|
|
test("G14 rejects executor implementation imports from src/app", async () => {
|
|
for (const importPath of [
|
|
"@omniroute/open-sse/executors/default.ts",
|
|
"open-sse/executors/default.ts",
|
|
]) {
|
|
const messages = await restrictedImportMessages(
|
|
`import { DefaultExecutor } from "${importPath}";\nvoid DefaultExecutor;`,
|
|
"src/app/api/example/route.ts"
|
|
);
|
|
|
|
assert.equal(messages.length, 1, `expected ${importPath} to be rejected from src/app`);
|
|
assert.match(messages[0], /handler or service boundary/);
|
|
}
|
|
});
|
|
|
|
test("G14 allows imports through the intended boundaries", async () => {
|
|
const cases = [
|
|
{
|
|
code: 'import { getSettings } from "@/lib/localDb";\nvoid getSettings;',
|
|
filePath: "src/lib/db/example.ts",
|
|
},
|
|
{
|
|
code: 'import { DefaultExecutor } from "@omniroute/open-sse/executors/default.ts";\nvoid DefaultExecutor;',
|
|
filePath: "src/sse/handlers/example.ts",
|
|
},
|
|
{
|
|
code: 'import { handleChat } from "@omniroute/open-sse/handlers/chat";\nvoid handleChat;',
|
|
filePath: "src/app/api/example/route.ts",
|
|
},
|
|
];
|
|
|
|
for (const fixture of cases) {
|
|
assert.deepEqual(await restrictedImportMessages(fixture.code, fixture.filePath), []);
|
|
}
|
|
});
|