Files
OmniRoute/tests/unit/exclusive-lease-managed-set.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

100 lines
2.9 KiB
TypeScript

import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import test from "node:test";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-lease-managed-set-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
const core = await import("../../src/lib/db/core.ts");
const apiKeys = await import("../../src/lib/db/apiKeys.ts");
await apiKeys.getApiKeys();
function insertKey(input: {
id: string;
allowedConnections: string[];
scopes: string[];
isActive?: boolean;
revokedAt?: string | null;
expiresAt?: string | null;
}): void {
core
.getDbInstance()
.prepare(
`INSERT INTO api_keys
(id, name, key, machine_id, allowed_models, allowed_connections, scopes, no_log, is_active,
revoked_at, expires_at, created_at)
VALUES (?, ?, ?, 'test', '[]', ?, ?, 1, ?, ?, ?, ?)`
)
.run(
input.id,
input.id,
`sk-${input.id}`,
JSON.stringify(input.allowedConnections),
JSON.stringify(input.scopes),
input.isActive === false ? 0 : 1,
input.revokedAt ?? null,
input.expiresAt ?? null,
new Date().toISOString()
);
}
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("derives the overlapping managed set from active scoped key allowlists", async () => {
insertKey({
id: "managed-a",
allowedConnections: ["conn-a", "conn-overlap"],
scopes: ["lease:exclusive"],
});
insertKey({
id: "managed-b",
allowedConnections: ["conn-b", "conn-overlap"],
scopes: ["lease:exclusive"],
});
insertKey({ id: "ordinary", allowedConnections: ["conn-unmanaged"], scopes: [] });
insertKey({
id: "inactive",
allowedConnections: ["conn-inactive"],
scopes: ["lease:exclusive"],
isActive: false,
});
insertKey({
id: "revoked",
allowedConnections: ["conn-revoked"],
scopes: ["lease:exclusive"],
revokedAt: new Date().toISOString(),
});
insertKey({
id: "expired",
allowedConnections: ["conn-expired"],
scopes: ["lease:exclusive"],
expiresAt: "2020-01-01T00:00:00.000Z",
});
const managed = await apiKeys.getExclusiveLeaseConnectionIds();
assert.deepEqual([...managed].sort(), ["conn-a", "conn-b", "conn-overlap"]);
});
test("re-derives managed membership after a key expires without cache clearing", async () => {
insertKey({
id: "managed-expiring",
allowedConnections: ["conn-expiring"],
scopes: ["lease:exclusive"],
});
assert.equal((await apiKeys.getExclusiveLeaseConnectionIds()).has("conn-expiring"), true);
core
.getDbInstance()
.prepare("UPDATE api_keys SET expires_at = ? WHERE id = ?")
.run("2020-01-01T00:00:00.000Z", "managed-expiring");
assert.equal((await apiKeys.getExclusiveLeaseConnectionIds()).has("conn-expiring"), false);
});