mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
105 lines
3.2 KiB
TypeScript
105 lines
3.2 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(
|
|
path.join(os.tmpdir(), "omniroute-execute-web-search-fallback-")
|
|
);
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const { executeWebSearch } = await import("../../src/lib/search/executeWebSearch.ts");
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
async function seedConnection(
|
|
provider: string,
|
|
overrides: {
|
|
apiKey?: string | null;
|
|
authType?: string;
|
|
providerSpecificData?: Record<string, unknown>;
|
|
} = {}
|
|
) {
|
|
return providersDb.createProviderConnection({
|
|
provider,
|
|
authType: overrides.authType || "apikey",
|
|
name: `${provider}-${Math.random().toString(16).slice(2, 8)}`,
|
|
apiKey: overrides.apiKey ?? "test-key",
|
|
isActive: true,
|
|
testStatus: "active",
|
|
providerSpecificData: overrides.providerSpecificData || {},
|
|
});
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
// Regression test for #11524 — executeWebSearch must prefer a credentialed
|
|
// provider over duckduckgo-free when the initially selected provider has no credentials.
|
|
test("auto-selects credentialed provider before duckduckgo-free fallback (#11524)", async () => {
|
|
await seedConnection("brave-search", { apiKey: "brave-key" });
|
|
|
|
const originalFetch = globalThis.fetch;
|
|
const fetchCalls: string[] = [];
|
|
|
|
globalThis.fetch = async (url, _init = {}) => {
|
|
const urlStr = String(url);
|
|
fetchCalls.push(urlStr);
|
|
|
|
if (urlStr.includes("api.search.brave.com")) {
|
|
return new Response(
|
|
JSON.stringify({
|
|
web: {
|
|
results: [
|
|
{
|
|
title: "Brave result",
|
|
url: "https://example.com/brave",
|
|
description: "Brave search result",
|
|
},
|
|
],
|
|
totalCount: 1,
|
|
},
|
|
}),
|
|
{ status: 200, headers: { "content-type": "application/json" } }
|
|
);
|
|
}
|
|
|
|
throw new Error(`Unexpected fetch to ${urlStr} in auto-select path`);
|
|
};
|
|
|
|
try {
|
|
const result = await executeWebSearch({ query: "latest omniroute roadmap" });
|
|
|
|
assert.equal(
|
|
result.data.provider,
|
|
"brave-search",
|
|
"must use the configured credentialed provider, not duckduckgo-free"
|
|
);
|
|
assert.ok(
|
|
fetchCalls.some((url) => url.includes("api.search.brave.com")),
|
|
"must call the Brave Search endpoint"
|
|
);
|
|
assert.ok(
|
|
!fetchCalls.some((url) => url.includes("duckduckgo.com")),
|
|
"duckduckgo-free must NOT be invoked when a credentialed provider is available (#11524)"
|
|
);
|
|
assert.equal(result.data.results.length, 1);
|
|
assert.equal(result.data.results[0].title, "Brave result");
|
|
} finally {
|
|
globalThis.fetch = originalFetch;
|
|
}
|
|
});
|