Files
OmniRoute/tests/unit/feature-triage/integration.test.mjs
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

161 lines
4.4 KiB
JavaScript

import { describe, it } from "node:test";
import assert from "node:assert/strict";
import { tmpdir } from "node:os";
import { mkdirSync, mkdtempSync, rmSync, readFileSync } from "node:fs";
import { join } from "node:path";
import { main } from "../../../scripts/features/feature-triage.mjs";
function makeDeps(state) {
return {
ghIssueListNumbers: () => state.openIssues.map((i) => i.number),
ghIssueListFeatureTitled: () => [],
ghIssueView: (_o, _r, n) => state.issuesById[n],
ghPrSearchMerged: (_o, _r, n) => state.prsByIssue[n] ?? [],
ghPrSearchOpen: (_o, _r, n) => state.openPrsByIssue?.[n] ?? [],
gitTagsByDate: () => state.tags ?? [],
gitLogGrep: (pattern) => state.commitsByPattern?.[pattern] ?? [],
gitIsAncestor: () => true,
gitCurrentReleaseBranch: () => state.releaseBranch ?? null,
};
}
function captureExit() {
const orig = process.exit;
let code = null;
process.exit = (c) => {
code = c;
throw new Error("__EXIT__");
};
return {
code: () => code,
restore: () => {
process.exit = orig;
},
};
}
describe("feature-triage integration", () => {
it("classifies 5 mixed issues into expected buckets", async () => {
const tmp = mkdtempSync(join(tmpdir(), "triage-"));
mkdirSync(join(tmp, "viable", "need_details"), { recursive: true });
mkdirSync(join(tmp, "defer"), { recursive: true });
const now = new Date();
const day = (n) => new Date(now.getTime() - n * 86400_000).toISOString();
const state = {
openIssues: [
{ number: 100 },
{ number: 200 },
{ number: 300 },
{ number: 400 },
{ number: 500 },
],
issuesById: {
100: {
number: 100,
title: "fresh",
url: "u",
author: { login: "a" },
createdAt: day(3),
labels: [],
assignees: [],
comments: [],
reactionGroups: [],
timelineItems: [],
},
200: {
number: 200,
title: "ripe",
url: "u",
author: { login: "b" },
createdAt: day(20),
labels: [],
assignees: [],
comments: [],
reactionGroups: [],
timelineItems: [],
},
300: {
number: 300,
title: "shipped",
url: "u",
author: { login: "c" },
createdAt: day(40),
labels: [],
assignees: [],
comments: [],
reactionGroups: [],
timelineItems: [],
},
400: {
number: 400,
title: "delegated",
url: "u",
author: { login: "d" },
createdAt: day(40),
labels: [],
assignees: [{ login: "alice" }],
comments: [],
reactionGroups: [],
timelineItems: [],
},
500: {
number: 500,
title: "in PR",
url: "u",
author: { login: "e" },
createdAt: day(40),
labels: [],
assignees: [],
comments: [],
reactionGroups: [],
},
},
openPrsByIssue: {
500: [{ number: 999, title: "WIP fix", body: "addresses #500" }],
},
prsByIssue: {
300: [
{
number: 1000,
title: "feat: shipped (closes #300)",
body: "closes #300",
mergedAt: day(10),
mergeCommit: { oid: "abc" },
},
],
},
tags: [{ date: new Date(now.getTime() - 5 * 86400_000), name: "v3.7.2" }],
releaseBranch: "release/v3.8.0",
};
const deps = makeDeps(state);
const outPath = join(tmp, "_triage.json");
const exit = captureExit();
try {
await main(
["--owner", "x", "--repo", "y", "--ideia-dir", tmp, "--output", outPath],
{},
deps
).catch((e) => {
if (e.message !== "__EXIT__") throw e;
});
} finally {
exit.restore();
}
assert.equal(exit.code(), 0);
const out = JSON.parse(readFileSync(outPath, "utf8"));
assert.equal(out.counts.dormant, 1);
assert.equal(out.counts.absorb, 1);
assert.equal(out.counts.already_delivered, 1);
assert.equal(out.counts.skip_assigned, 1);
assert.equal(out.counts.skip_has_pr, 1);
assert.equal(out.buckets.already_delivered[0].version, "v3.7.2");
rmSync(tmp, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
});