mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
86 lines
2.7 KiB
TypeScript
86 lines
2.7 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
import { handleNoCredentials } from "../../src/sse/handlers/chatHelpers.ts";
|
|
|
|
// #FIX: the "No active credentials for provider: X" 404 response used to be
|
|
// a wall of silence — operators had no way to know which providers actually
|
|
// catalog the model id they requested. Surface a hint listing the top 3
|
|
// candidate aliases (provider/model prefix form) so the operator can
|
|
// prefix and route to a working provider on the next request.
|
|
|
|
test("handleNoCredentials includes candidate aliases hint when supplied", async () => {
|
|
const res = handleNoCredentials(
|
|
/* credentials */ {},
|
|
/* excludeConnectionId */ null,
|
|
/* provider */ "kiro",
|
|
/* model */ "claude-opus-5",
|
|
/* lastError */ null,
|
|
/* lastStatus */ null,
|
|
/* candidateAliases */ ["anthropic", "claude", "agentrouter"],
|
|
/* isCombo */ true
|
|
);
|
|
|
|
assert.equal(res.status, 404);
|
|
const body = (await res.json()) as { error?: { message?: string } };
|
|
const message = body?.error?.message ?? "";
|
|
assert.match(
|
|
message,
|
|
/No active credentials for provider: kiro/,
|
|
"must keep the original error prefix"
|
|
);
|
|
assert.match(
|
|
message,
|
|
/Try one of: anthropic\/claude-opus-5, claude\/claude-opus-5, agentrouter\/claude-opus-5/,
|
|
"must append a candidate-prefix hint when candidates are provided"
|
|
);
|
|
});
|
|
|
|
test("handleNoCredentials omits hint when no candidates supplied", async () => {
|
|
const res = handleNoCredentials(
|
|
{},
|
|
null,
|
|
"kiro",
|
|
"claude-opus-5",
|
|
null,
|
|
null,
|
|
/* no candidateAliases */
|
|
undefined,
|
|
/* isCombo */ true
|
|
);
|
|
|
|
assert.equal(res.status, 404);
|
|
const body = (await res.json()) as { error?: { message?: string } };
|
|
const message = body?.error?.message ?? "";
|
|
assert.match(message, /No active credentials for provider: kiro/);
|
|
assert.doesNotMatch(
|
|
message,
|
|
/Try one of:/,
|
|
"must NOT append a hint when no candidates are provided"
|
|
);
|
|
});
|
|
|
|
test("handleNoCredentials trims candidate list to top 3", async () => {
|
|
const res = handleNoCredentials(
|
|
{},
|
|
null,
|
|
"kiro",
|
|
"claude-opus-5",
|
|
null,
|
|
null,
|
|
["anthropic", "claude", "agentrouter", "github", "vertex-partner"],
|
|
/* isCombo */ true
|
|
);
|
|
|
|
const body = (await res.json()) as { error?: { message?: string } };
|
|
const message = body?.error?.message ?? "";
|
|
// Top-3 (anthropic, claude, agentrouter) — github and vertex-partner are
|
|
// dropped to keep the hint actionable.
|
|
assert.match(
|
|
message,
|
|
/Try one of: anthropic\/claude-opus-5, claude\/claude-opus-5, agentrouter\/claude-opus-5/
|
|
);
|
|
assert.doesNotMatch(message, /github\/claude-opus-5/);
|
|
assert.doesNotMatch(message, /vertex-partner\/claude-opus-5/);
|
|
});
|