mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-10 08:52:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
96 lines
3.5 KiB
TypeScript
96 lines
3.5 KiB
TypeScript
import test, { after, before } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-copilot-retired-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const modelsDb = await import("../../src/lib/db/models.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
|
|
before(() => {
|
|
core.resetDbInstance();
|
|
});
|
|
|
|
after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("GitHub Copilot sync rejects retired Gemini models", async () => {
|
|
await modelsDb.replaceSyncedAvailableModelsForConnection("github", "copilot-current", [
|
|
{ id: "gemini-2.5-pro", name: "Gemini 2.5 Pro" },
|
|
{ id: "gemini-3-flash", name: "Gemini 3 Flash" },
|
|
{ id: "gemini-3-flash-preview", name: "Gemini 3 Flash Preview" },
|
|
{ id: "gemini-3.6-flash", name: "Gemini 3.6 Flash" },
|
|
]);
|
|
|
|
const ids = (await modelsDb.getSyncedAvailableModels("github")).map((model) => model.id);
|
|
assert.deepEqual(ids, ["gemini-3.6-flash"]);
|
|
});
|
|
|
|
test("GitHub Copilot readers hide retired models from legacy synced caches", async () => {
|
|
const db = core.getDbInstance();
|
|
db.prepare(
|
|
"INSERT INTO key_value (namespace, key, value) VALUES ('syncedAvailableModels', ?, ?)"
|
|
).run(
|
|
"github:copilot-legacy",
|
|
JSON.stringify([
|
|
{ id: "gemini-2.5-pro", name: "Gemini 2.5 Pro" },
|
|
{ id: "gemini-3-flash-preview", name: "Gemini 3 Flash" },
|
|
{ id: "gemini-3.6-flash", name: "Gemini 3.6 Flash" },
|
|
])
|
|
);
|
|
|
|
const connectionIds = (
|
|
await modelsDb.getSyncedAvailableModelsForConnection("github", "copilot-legacy")
|
|
).map((model) => model.id);
|
|
const providerIds = (await modelsDb.getSyncedAvailableModels("github")).map((model) => model.id);
|
|
const allProviderIds = (await modelsDb.getAllSyncedAvailableModels()).github.map(
|
|
(model) => model.id
|
|
);
|
|
|
|
assert.deepEqual(connectionIds, ["gemini-3.6-flash"]);
|
|
assert.deepEqual(providerIds, ["gemini-3.6-flash"]);
|
|
assert.deepEqual(allProviderIds, ["gemini-3.6-flash"]);
|
|
});
|
|
|
|
test("provider inference does not route retired Gemini models to GitHub Copilot", async () => {
|
|
const connection = await providersDb.createProviderConnection({
|
|
provider: "github",
|
|
authType: "oauth",
|
|
name: "copilot-retired-routing",
|
|
accessToken: "github-test-token",
|
|
isActive: true,
|
|
testStatus: "active",
|
|
});
|
|
const db = core.getDbInstance();
|
|
db.prepare(
|
|
"INSERT INTO key_value (namespace, key, value) VALUES ('syncedAvailableModels', ?, ?)"
|
|
).run(
|
|
`github:${connection.id}`,
|
|
JSON.stringify([
|
|
{ id: "gemini-2.5-pro", name: "Gemini 2.5 Pro" },
|
|
{ id: "gemini-3.6-flash", name: "Gemini 3.6 Flash" },
|
|
])
|
|
);
|
|
|
|
assert.deepEqual(await modelsDb.getActiveProvidersWithSyncedModel("gemini-2.5-pro"), []);
|
|
assert.deepEqual(await modelsDb.getActiveProvidersWithSyncedModel("gemini-3.6-flash"), [
|
|
"github",
|
|
]);
|
|
});
|
|
|
|
test("retirement remains scoped to GitHub Copilot", async () => {
|
|
await modelsDb.replaceSyncedAvailableModelsForConnection("gemini", "gemini-direct", [
|
|
{ id: "gemini-2.5-pro", name: "Gemini 2.5 Pro" },
|
|
{ id: "gemini-3-flash", name: "Gemini 3 Flash" },
|
|
]);
|
|
|
|
const ids = (await modelsDb.getSyncedAvailableModels("gemini")).map((model) => model.id);
|
|
assert.deepEqual(ids, ["gemini-2.5-pro", "gemini-3-flash"]);
|
|
});
|