mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-15 11:22:15 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
80 lines
3.3 KiB
TypeScript
80 lines
3.3 KiB
TypeScript
/**
|
|
* Test-only workaround for the inherited base-red "Migration version collision
|
|
* detected" on release/v3.8.50 (originally the `134_ccr_blocks.sql` +
|
|
* `134_proxy_logs_egress_ip.sql` pair, fixed by #9688; the surviving pair is
|
|
* `135_connection_runtime_state.sql` + `135_migrate_model_capability_max_token.sql`,
|
|
* fix #9676 in flight). Any test that exercises a code path opening
|
|
* the DB (e.g. `VisionBridgeGuardrail.preCall` → `getResolvedModelCapabilities`
|
|
* → `getDbInstance`) dies at migration-file scan time, BEFORE the code under
|
|
* test runs — making TDD on those paths impossible until the base is fixed.
|
|
*
|
|
* Base-red tracking: issue #9679; remaining fix PR in flight: #9676 (#9688
|
|
* already landed). Once the base has no duplicate prefixes the copy and
|
|
* this degrades to a plain pass-through copy — at that point this helper (and
|
|
* its callsites) can be removed. Grep trigger: 9679 / 9676 / 9688.
|
|
*
|
|
* This helper copies the real migrations into a temp dir, renumbering any file
|
|
* whose numeric prefix duplicates an earlier one to a fresh (max+1) version,
|
|
* and points `OMNIROUTE_MIGRATIONS_DIR` (supported operator env var — see
|
|
* `src/lib/db/migrationRunner.ts::resolveMigrationsDir`) at the copy. On the
|
|
* FRESH per-process test DATA_DIR (tests/_setup/isolateDataDir.ts) the schema
|
|
* CONTENT applied is byte-identical, but note the renumbering does shift the
|
|
* displaced duplicate to the END of the migration ORDER (it runs after every
|
|
* lower-numbered file instead of at its original slot). Harmless for the
|
|
* current colliding pair — and strictly better than the crash — but not
|
|
* literally "the same run" as production.
|
|
*
|
|
* MUST be called before the first `getDbInstance()` in the process (i.e. at
|
|
* test-file top level, before any `preCall`). An explicitly configured
|
|
* `OMNIROUTE_MIGRATIONS_DIR` always wins.
|
|
*/
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
export function useDecollidedMigrationsDir(): void {
|
|
if (process.env.OMNIROUTE_MIGRATIONS_DIR) return;
|
|
|
|
const realDir = path.resolve("src/lib/db/migrations");
|
|
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-test-migrations-"));
|
|
|
|
const files = fs
|
|
.readdirSync(realDir, { withFileTypes: true })
|
|
.filter((entry) => entry.isFile())
|
|
.map((entry) => entry.name)
|
|
.sort();
|
|
|
|
let maxVersion = 0;
|
|
for (const file of files) {
|
|
const match = file.match(/^(\d+)_/);
|
|
if (match) maxVersion = Math.max(maxVersion, Number.parseInt(match[1], 10));
|
|
}
|
|
|
|
const seenVersions = new Set<number>();
|
|
for (const file of files) {
|
|
const match = file.match(/^(\d+)_(.*)$/);
|
|
let target = file;
|
|
if (match) {
|
|
const version = Number.parseInt(match[1], 10);
|
|
if (seenVersions.has(version)) {
|
|
// Collision: move the later duplicate to a fresh version slot.
|
|
maxVersion += 1;
|
|
target = `${maxVersion}_${match[2]}`;
|
|
} else {
|
|
seenVersions.add(version);
|
|
}
|
|
}
|
|
fs.copyFileSync(path.join(realDir, file), path.join(tmp, target));
|
|
}
|
|
|
|
process.env.OMNIROUTE_MIGRATIONS_DIR = tmp;
|
|
|
|
process.on("exit", () => {
|
|
try {
|
|
fs.rmSync(tmp, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {
|
|
// Best-effort cleanup — the OS reaps its temp dir eventually.
|
|
}
|
|
});
|
|
}
|