Files
OmniRoute/tests/unit/image-compat-node-alias-shadow.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

79 lines
2.8 KiB
TypeScript

/**
* Regression test — ported from decolua/9router commit 047fdc89:
* "fix(image): prevent compatible nodes from shadowing provider aliases"
*
* A user-defined openai-compatible provider node with `prefix: "cf"` must NOT
* shadow the built-in `cloudflare-ai` provider (alias `cf`). Cloudflare image
* routes like `cf/@cf/black-forest-labs/...` must keep resolving to the
* built-in cloudflare-ai provider, regardless of any compatible-node prefix
* collision.
*
* Inverse case: a non-reserved compatible-node prefix (e.g. `oct`) must still
* resolve to the compatible node. The fix is a reserved-prefix guard — it must
* not break user-defined prefixes that don't collide with built-in aliases.
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-image-compat-shadow-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const { getModelInfo } = await import("../../src/sse/services/model.ts");
test.before(async () => {
await providersDb.createProviderNode({
id: "openai-compatible-cf-collision",
type: "openai-compatible",
name: "Compatible CF Collision",
prefix: "cf",
baseUrl: "https://compatible.test/v1",
chatPath: "/v1/chat/completions",
modelsPath: "/v1/models",
});
await providersDb.createProviderNode({
id: "openai-compatible-oct-passthrough",
type: "openai-compatible",
name: "Compatible OCT",
prefix: "oct",
baseUrl: "https://compatible-oct.test/v1",
chatPath: "/v1/chat/completions",
modelsPath: "/v1/models",
});
});
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("compatible node with prefix=cf must NOT shadow the built-in cloudflare-ai alias", async () => {
const info = (await getModelInfo("cf/@cf/black-forest-labs/flux-2-klein-9b")) as {
provider?: string;
model?: string;
};
assert.equal(
info.provider,
"cloudflare-ai",
"cf/ must keep routing to the built-in cloudflare-ai provider (not the compatible node)"
);
assert.equal(info.model, "@cf/black-forest-labs/flux-2-klein-9b");
});
test("non-reserved compatible-node prefix (oct) still routes to the compatible node", async () => {
const info = (await getModelInfo("oct/gpt-image-1")) as {
provider?: string;
model?: string;
};
assert.equal(
info.provider,
"openai-compatible-oct-passthrough",
"user-defined prefixes that don't collide with built-in aliases must still resolve to the compatible node"
);
assert.equal(info.model, "gpt-image-1");
});